Subject: Re: [PATCH net-next] neighbor: Add protocol attribute

From: David Ahern <[email-masked]>
Date: Mon, 10 Dec 2018 19:47:33 -0700

On 12/7/18 4:45 PM, David Miller wrote:
> 
> Right, neigh->ha[] should probably be kept 8-byte aligned.
> 

>>From what I can see ha is only used with memcpy, and neighbour struct is
annotated with __randomize_layout. Are you saying that ha should be
marked with __aligned(8)?

@@ -150,7 +150,7 @@ struct neighbour {
        __u8                    type;
        __u8                    dead;
        seqlock_t               ha_lock;
-       unsigned char           ha[ALIGN(MAX_ADDR_LEN, sizeof(unsigned
long))];
+       unsigned char           ha[ALIGN(MAX_ADDR_LEN, sizeof(unsigned
long))] __aligned(8);
        struct hh_cache         hh;
        int                     (*output)(struct neighbour *, struct
sk_buff *);
        const struct neigh_ops  *ops;