From: Alan Brady <alan.brady@intel•com>
To: Jakub Kicinski <kuba@kernel•org>,
Tony Nguyen <anthony.l.nguyen@intel•com>
Cc: <davem@davemloft•net>, <pabeni@redhat•com>, <edumazet@google•com>,
<netdev@vger•kernel.org>, <yoshfuji@linux-ipv6•org>,
<dsahern@kernel•org>, Gurucharan <gurucharanx.g@intel•com>
Subject: Re: [PATCH net-next 1/1] ping: fix ipv6 ping socket flow labels
Date: Wed, 13 Jul 2022 15:48:02 -0700 [thread overview]
Message-ID: <ececa999-1e66-ecb8-972a-1dc2ba8d64fc@intel.com> (raw)
In-Reply-To: <20220713124930.6d58af50@kernel.org>
On 7/13/2022 12:49 PM, Jakub Kicinski wrote:
> On Tue, 12 Jul 2022 09:56:08 -0700 Tony Nguyen wrote:
>> From: Alan Brady <alan.brady@intel•com>
>>
>> Ping sockets don't appear to make any attempt to preserve flow labels
>> created and set by userspace. Instead they are always clobbered by
>> autolabels (if enabled) or zero.
>>
>> This grabs the flowlabel out of the msghdr similar to how rawv6_sendmsg
>> does it and moves the memset up so we don't zero it.
>>
>> Signed-off-by: Alan Brady <alan.brady@intel•com>
>> Tested-by: Gurucharan <gurucharanx.g@intel•com> (A Contingent worker at Intel)
>> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel•com>
>
> Thanks! Please add a selftest and s/fix/support/ in the subject
> otherwise the stable ML bot will think this is a fix, and its more
> of a missing feature.
Gotcha, will do both, thanks!
prev parent reply other threads:[~2022-07-13 22:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 16:56 [PATCH net-next 1/1] ping: fix ipv6 ping socket flow labels Tony Nguyen
2022-07-13 19:49 ` Jakub Kicinski
2022-07-13 22:48 ` Alan Brady [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ececa999-1e66-ecb8-972a-1dc2ba8d64fc@intel.com \
--to=alan.brady@intel$(echo .)com \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=gurucharanx.g@intel$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox