From: "Linga, Pavan Kumar" <pavan.kumar.linga@intel•com>
To: Simon Horman <simon.horman@corigine•com>
Cc: <intel-wired-lan@lists•osuosl.org>, <netdev@vger•kernel.org>,
<shiraz.saleem@intel•com>, <emil.s.tantilov@intel•com>,
<willemb@google•com>, <decot@google•com>,
<joshua.a.hay@intel•com>, <sridhar.samudrala@intel•com>,
Alan Brady <alan.brady@intel•com>,
Madhu Chittim <madhu.chittim@intel•com>,
Phani Burra <phani.r.burra@intel•com>
Subject: Re: [Intel-wired-lan] [PATCH net-next 09/15] idpf: initialize interrupts and enable vport
Date: Wed, 5 Apr 2023 01:06:49 +0530 [thread overview]
Message-ID: <ee6468d3-8212-7bbc-447b-6c659727f5fd@intel.com> (raw)
In-Reply-To: <ZCcDabCHzjXeN+xI@corigine.com>
On 3/31/2023 9:29 PM, Simon Horman wrote:
> On Wed, Mar 29, 2023 at 07:03:58AM -0700, Pavan Kumar Linga wrote:
>> To further continue 'vport open', initialize all the resources
>> required for the interrupts. To start with, initialize the
>> queue vector indices with the ones received from the device
>> Control Plane. Now that all the TX and RX queues are initialized,
>> map the RX descriptor and buffer queues as well as TX completion
>> queues to the allocated vectors. Initialize and enable the napi
>> handler for the napi polling. Finally, request the IRQs for the
>> interrupt vectors from the stack and setup the interrupt handler.
>>
>> Once the interrupt init is done, send 'map queue vector', 'enable
>> queues' and 'enable vport' virtchnl messages to the CP to complete
>> the 'vport open' flow.
>>
>> Co-developed-by: Alan Brady <alan.brady@intel•com>
>> Signed-off-by: Alan Brady <alan.brady@intel•com>
>> Co-developed-by: Joshua Hay <joshua.a.hay@intel•com>
>> Signed-off-by: Joshua Hay <joshua.a.hay@intel•com>
>> Co-developed-by: Madhu Chittim <madhu.chittim@intel•com>
>> Signed-off-by: Madhu Chittim <madhu.chittim@intel•com>
>> Co-developed-by: Phani Burra <phani.r.burra@intel•com>
>> Signed-off-by: Phani Burra <phani.r.burra@intel•com>
>> Signed-off-by: Pavan Kumar Linga <pavan.kumar.linga@intel•com>
>> Reviewed-by: Sridhar Samudrala <sridhar.samudrala@intel•com>
>
> Spelling from me again.
> I think I'll stop there and just mention that you might want to consider
> adding ./checkpatch.pl --codespell to your CI.
>
>
Thanks for pointing at the misspells. Fixed all of them by running
codespell through all the patches. Changes will be part of the v2
version. As suggested, will add the 'codespell' into the CI to catch any
misspells in advance, during the code development.
>> diff --git a/drivers/net/ethernet/intel/idpf/idpf_lib.c b/drivers/net/ethernet/intel/idpf/idpf_lib.c
>
> ...
>
>> +/**
>> + * idpf_up_complete - Complete interface up sequence
>> + * @vport: virtual port strucutre
>> + *
>> + * Returns 0 on success, negative on failure.
>> + */
>
> s/strucutre/structure/
>
> ...
Thanks,
Pavan
next prev parent reply other threads:[~2023-04-04 19:37 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 14:03 [Intel-wired-lan] [PATCH net-next 00/15] Introduce IDPF driver Pavan Kumar Linga
2023-03-29 14:03 ` [Intel-wired-lan] [PATCH net-next 01/15] virtchnl: add virtchnl version 2 ops Pavan Kumar Linga
2023-03-31 15:25 ` Simon Horman
2023-04-03 22:01 ` Shannon Nelson
2023-04-03 22:20 ` Jakub Kicinski
2023-04-03 22:54 ` Shannon Nelson
2023-04-03 23:30 ` Jakub Kicinski
2023-04-04 7:59 ` Orr, Michael
2023-04-04 16:25 ` Shannon Nelson
2023-04-04 19:41 ` Orr, Michael
2023-04-10 20:27 ` Linga, Pavan Kumar
2023-04-10 22:12 ` Shannon Nelson
2023-04-12 16:58 ` Tantilov, Emil S
2023-04-12 21:36 ` Shannon Nelson
2023-04-13 18:54 ` Tantilov, Emil S
2023-04-13 21:03 ` Shannon Nelson
2023-03-29 14:03 ` [Intel-wired-lan] [PATCH net-next 02/15] idpf: add module register and probe functionality Pavan Kumar Linga
2023-03-29 14:03 ` [Intel-wired-lan] [PATCH net-next 03/15] idpf: add controlq init and reset checks Pavan Kumar Linga
2023-03-29 14:03 ` [Intel-wired-lan] [PATCH net-next 04/15] idpf: add core init and interrupt request Pavan Kumar Linga
2023-03-31 15:39 ` Simon Horman
2023-03-29 14:03 ` [Intel-wired-lan] [PATCH net-next 05/15] idpf: add create vport and netdev configuration Pavan Kumar Linga
2023-03-31 15:46 ` Simon Horman
2023-03-29 14:03 ` [Intel-wired-lan] [PATCH net-next 06/15] idpf: continue expanding init task Pavan Kumar Linga
2023-03-31 15:47 ` Simon Horman
2023-03-29 14:03 ` [Intel-wired-lan] [PATCH net-next 07/15] idpf: configure resources for TX queues Pavan Kumar Linga
2023-03-31 15:49 ` Simon Horman
2023-03-29 14:03 ` [Intel-wired-lan] [PATCH net-next 08/15] idpf: configure resources for RX queues Pavan Kumar Linga
2023-03-29 14:03 ` [Intel-wired-lan] [PATCH net-next 09/15] idpf: initialize interrupts and enable vport Pavan Kumar Linga
2023-03-31 15:59 ` Simon Horman
2023-04-04 19:36 ` Linga, Pavan Kumar [this message]
2023-04-05 10:07 ` Simon Horman
2023-03-29 14:03 ` [Intel-wired-lan] [PATCH net-next 10/15] idpf: add splitq start_xmit Pavan Kumar Linga
2023-03-29 14:04 ` [Intel-wired-lan] [PATCH net-next 11/15] idpf: add TX splitq napi poll support Pavan Kumar Linga
2023-03-29 14:04 ` [Intel-wired-lan] [PATCH net-next 12/15] idpf: add RX " Pavan Kumar Linga
2023-03-30 16:23 ` Maciej Fijalkowski
2023-04-05 0:51 ` Tantilov, Emil S
2023-03-29 14:04 ` [Intel-wired-lan] [PATCH net-next 13/15] idpf: add singleq start_xmit and napi poll Pavan Kumar Linga
2023-03-29 14:04 ` [Intel-wired-lan] [PATCH net-next 14/15] idpf: add ethtool callbacks Pavan Kumar Linga
2023-03-29 15:33 ` Andrew Lunn
2023-03-30 22:05 ` Linga, Pavan Kumar
2023-03-29 14:04 ` [Intel-wired-lan] [PATCH net-next 15/15] idpf: configure SRIOV and add other ndo_ops Pavan Kumar Linga
2023-03-29 15:41 ` [Intel-wired-lan] [PATCH net-next 00/15] Introduce IDPF driver Paul Menzel
2023-03-30 21:31 ` Linga, Pavan Kumar
2023-03-29 17:31 ` Willem de Bruijn
2023-03-30 12:03 ` Jason Gunthorpe
2023-03-30 17:25 ` Jakub Kicinski
2023-03-30 18:29 ` Jason Gunthorpe
2023-04-03 21:36 ` Samudrala, Sridhar
2023-04-04 16:42 ` Jason Gunthorpe
2023-04-04 19:19 ` Orr, Michael
2023-04-04 23:35 ` Jason Gunthorpe
2023-04-07 4:39 ` Christoph Hellwig
2023-04-07 18:01 ` Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee6468d3-8212-7bbc-447b-6c659727f5fd@intel.com \
--to=pavan.kumar.linga@intel$(echo .)com \
--cc=alan.brady@intel$(echo .)com \
--cc=decot@google$(echo .)com \
--cc=emil.s.tantilov@intel$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=joshua.a.hay@intel$(echo .)com \
--cc=madhu.chittim@intel$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=phani.r.burra@intel$(echo .)com \
--cc=shiraz.saleem@intel$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
--cc=sridhar.samudrala@intel$(echo .)com \
--cc=willemb@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox