From: Christoph Niedermaier <cniedermaier@dh-electronics•com>
To: "netdev@vger•kernel.org" <netdev@vger•kernel.org>
Cc: Andrew Lunn <andrew@lunn•ch>,
Richard Leitner <richard.leitner@skidata•com>,
"David S . Miller" <davem@davemloft•net>,
"NXP Linux Team" <linux-imx@nxp•com>,
Shawn Guo <shawnguo@kernel•org>, "'Marek Vasut'" <marex@denx•de>,
Christoph Niedermaier <cniedermaier@dh-electronics•com>
Subject: RE: [PATCH][RESEND] net: fec: Fix PHY init after phy_reset_after_clk_enable() [Klartext]
Date: Tue, 6 Oct 2020 19:07:14 +0000 [thread overview]
Message-ID: <f3ff40567ee44fc3a14b2ae8a9b18180@dh-electronics.com> (raw)
From: Marek Vasut <marex@denx•de>
Sent: Tuesday, October 6, 2020 3:53 PM
> The phy_reset_after_clk_enable() does a PHY reset, which means the PHY
> loses its register settings. The fec_enet_mii_probe() starts the PHY
> and does the necessary calls to configure the PHY via PHY framework,
> and loads the correct register settings into the PHY. Therefore,
> fec_enet_mii_probe() should be called only after the PHY has been
> reset, not before as it is now.
>
> Fixes: 1b0a83ac04e3 ("net: fec: add phy_reset_after_clk_enable() support")
> Reviewed-by: Andrew Lunn <andrew@lunn•ch>
> Tested-by: Richard Leitner <richard.leitner@skidata•com>
> Signed-off-by: Marek Vasut <marex@denx•de>
> Cc: Christoph Niedermaier <cniedermaier@dh-electronics•com>
> Cc: David S. Miller <davem@davemloft•net>
> Cc: NXP Linux Team <linux-imx@nxp•com>
> Cc: Richard Leitner <richard.leitner@skidata•com>
> Cc: Shawn Guo <shawnguo@kernel•org>
> ---
> drivers/net/ethernet/freescale/fec_main.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index c043afb38b6e..2d5433301843 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2983,17 +2983,17 @@ fec_enet_open(struct net_device *ndev)
> /* Init MAC prior to mii bus probe */
> fec_restart(ndev);
>
> - /* Probe and connect to PHY when open the interface */
> - ret = fec_enet_mii_probe(ndev);
> - if (ret)
> - goto err_enet_mii_probe;
> -
> /* Call phy_reset_after_clk_enable() again if it failed during
> * phy_reset_after_clk_enable() before because the PHY wasn't
> probed.
> */
> if (reset_again)
> phy_reset_after_clk_enable(ndev->phydev);
>
> + /* Probe and connect to PHY when open the interface */
> + ret = fec_enet_mii_probe(ndev);
> + if (ret)
> + goto err_enet_mii_probe;
> +
> if (fep->quirks & FEC_QUIRK_ERR006687)
> imx6q_cpuidle_fec_irqs_used();
>
> --
> 2.28.0
Tested-by: Christoph Niedermaier <cniedermaier@dh-electronics•com>
reply other threads:[~2020-10-06 19:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3ff40567ee44fc3a14b2ae8a9b18180@dh-electronics.com \
--to=cniedermaier@dh-electronics$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=linux-imx@nxp$(echo .)com \
--cc=marex@denx$(echo .)de \
--cc=netdev@vger$(echo .)kernel.org \
--cc=richard.leitner@skidata$(echo .)com \
--cc=shawnguo@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox