From: Heiner Kallweit <hkallweit1@gmail•com>
To: Andrew Lunn <andrew@lunn•ch>
Cc: David Miller <davem@davemloft•net>,
Florian Fainelli <f.fainelli@gmail•com>,
Realtek linux nic maintainers <nic_swsd@realtek•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next v2 02/10] r8169: use phy_resume/phy_suspend
Date: Tue, 10 Jul 2018 21:32:01 +0200 [thread overview]
Message-ID: <f8802230-9e7d-a749-e787-ba80794f4e62@gmail.com> (raw)
In-Reply-To: <20180710191509.GC11754@lunn.ch>
On 10.07.2018 21:15, Andrew Lunn wrote:
>> static void r8168_pll_power_down(struct rtl8169_private *tp)
>> {
>> if (r8168_check_dash(tp))
>> @@ -4503,7 +4462,8 @@ static void r8168_pll_power_down(struct rtl8169_private *tp)
>> if (rtl_wol_pll_power_down(tp))
>> return;
>>
>> - r8168_phy_power_down(tp);
>> + /* cover the case that PHY isn't connected */
>> + phy_suspend(mdiobus_get_phy(tp->mii_bus, 0));
>
> I don't particularly like this, because no other MAC driver does it.
>
I have to agree, it doesn't look too nice.
In general quite few network drivers seem to use runtime pm.
> Why is it powered up, but not connected? Is it powered down before it
> is disconnected? Is it the bootloader which is powering it up?
>
Exactly, if the device is active when driver is loaded and the
interface isn't used and therefore not brought up, then, when runtime-
suspending, we face this situation.
This could be changed by connecting the PHY in probe() already instead
of doing it in open(). I had this in the beginning, based on a
recommendation from Florian or you (don't remember) I changed this to
connect in open() only.
Do you have any preference or see a good way to deal with the situation?
Heiner
> Andrew
>
next prev parent reply other threads:[~2018-07-10 19:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 18:29 [PATCH net-next v2 00/10] r8169: add phylib support Heiner Kallweit
2018-07-10 18:39 ` [PATCH net-next v2 01/10] r8169: add basic " Heiner Kallweit
2018-07-10 19:10 ` Andrew Lunn
2018-07-10 19:20 ` Heiner Kallweit
2018-07-10 18:39 ` [PATCH net-next v2 02/10] r8169: use phy_resume/phy_suspend Heiner Kallweit
2018-07-10 19:15 ` Andrew Lunn
2018-07-10 19:32 ` Heiner Kallweit [this message]
2018-07-10 20:52 ` Andrew Lunn
2018-07-10 21:42 ` Heiner Kallweit
2018-07-10 21:56 ` Heiner Kallweit
2018-07-10 18:39 ` [PATCH net-next v2 03/10] r8169: replace open-coded PHY soft reset with genphy_soft_reset Heiner Kallweit
2018-07-11 11:10 ` Florian Fainelli
2018-07-10 18:39 ` [PATCH net-next v2 04/10] r8169: use phy_ethtool_(g|s)et_link_ksettings Heiner Kallweit
2018-07-10 20:34 ` Andrew Lunn
2018-07-11 11:10 ` Florian Fainelli
2018-07-10 18:39 ` [PATCH net-next v2 05/10] r8169: use phy_ethtool_nway_reset Heiner Kallweit
2018-07-11 11:11 ` Florian Fainelli
2018-07-10 18:39 ` [PATCH net-next v2 06/10] r8169: use phy_mii_ioctl Heiner Kallweit
2018-07-11 11:11 ` Florian Fainelli
2018-07-10 18:39 ` [PATCH net-next v2 07/10] r8169: migrate speed_down function to phylib Heiner Kallweit
2018-07-10 20:44 ` Andrew Lunn
2018-07-10 21:26 ` Heiner Kallweit
2018-07-10 21:40 ` Andrew Lunn
2018-07-10 18:39 ` [PATCH net-next v2 08/10] r8169: remove rtl8169_set_speed_xmii Heiner Kallweit
2018-07-10 18:40 ` [PATCH net-next v2 09/10] r8169: remove mii_if_info member from struct rtl8169_private Heiner Kallweit
2018-07-10 20:53 ` Andrew Lunn
2018-07-10 21:00 ` Andrew Lunn
2018-07-10 21:32 ` Heiner Kallweit
2018-07-10 21:37 ` Andrew Lunn
2018-07-10 18:40 ` [PATCH net-next v2 10/10] r8169: don't read chip phy status register Heiner Kallweit
2018-07-11 11:12 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8802230-9e7d-a749-e787-ba80794f4e62@gmail.com \
--to=hkallweit1@gmail$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nic_swsd@realtek$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox