From: David Ahern <dsahern@gmail•com>
To: Xin Long <lucien.xin@gmail•com>, network dev <netdev@vger•kernel.org>
Cc: davem@davemloft•net, Davide Caratti <dcaratti@redhat•com>,
idosch@idosch•org
Subject: Re: [PATCHv2 net-next 2/2] selftests: add a selftest for directed broadcast forwarding
Date: Mon, 2 Jul 2018 09:12:25 -0600 [thread overview]
Message-ID: <fc462436-af77-2c95-ec79-6cc418ef126e@gmail.com> (raw)
In-Reply-To: <03b43b2dbda208510514082b2bd94643c3a6580c.1530512974.git.lucien.xin@gmail.com>
On 7/2/18 12:30 AM, Xin Long wrote:
> +ping_ipv4()
> +{
> + sysctl_set net.ipv4.icmp_echo_ignore_broadcasts 0
> + bc_forwarding_disable
> + ping_test $h1 198.51.100.255
> +
> + iptables -A INPUT -i vrf-r1 -p icmp -j DROP
> + bc_forwarding_restore
> + bc_forwarding_enable
> + ping_test $h1 198.51.100.255
> +
> + bc_forwarding_restore
> + iptables -D INPUT -i vrf-r1 -p icmp -j DROP
> + sysctl_restore net.ipv4.icmp_echo_ignore_broadcasts
> +}
Both tests fail for me:
TEST: ping [FAIL]
TEST: ping [FAIL]
Why the need for the iptables rule?
And, PAUSE_ON_FAIL is not working to take a look at why tests are
failing. e.g.,
PAUSE_ON_FAIL=yes ./router_broadcast.sh
just continues on. Might be something with the infrastructure scripts.
next prev parent reply other threads:[~2018-07-02 15:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 6:30 [PATCHv2 net-next 0/2] route: add support and selftests for directed broadcast forwarding Xin Long
2018-07-02 6:30 ` [PATCHv2 net-next 1/2] route: add support " Xin Long
2018-07-02 9:57 ` Davide Caratti
2018-07-02 15:05 ` David Ahern
2018-07-03 11:38 ` Xin Long
2018-07-02 6:30 ` [PATCHv2 net-next 2/2] selftests: add a selftest " Xin Long
2018-07-02 15:12 ` David Ahern [this message]
2018-07-03 11:36 ` Xin Long
2018-07-03 19:23 ` David Ahern
2018-07-04 17:56 ` Xin Long
2018-07-04 18:31 ` David Ahern
2018-07-04 18:36 ` David Ahern
2018-07-05 7:57 ` Xin Long
2018-07-05 13:18 ` David Ahern
2018-07-05 14:07 ` Xin Long
2018-07-06 9:50 ` Xin Long
2018-07-07 14:51 ` David Ahern
2018-07-04 20:39 ` Ido Schimmel
2018-07-05 8:21 ` Xin Long
2018-07-05 15:38 ` Xin Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc462436-af77-2c95-ec79-6cc418ef126e@gmail.com \
--to=dsahern@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dcaratti@redhat$(echo .)com \
--cc=idosch@idosch$(echo .)org \
--cc=lucien.xin@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox