From: Mat Martineau <martineau@kernel•org>
To: Eric Dumazet <edumazet@google•com>
Cc: "David S . Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>,
Paolo Abeni <pabeni@redhat•com>,
Matthieu Baerts <matttbe@kernel•org>,
Geliang Tang <geliang.tang@linux•dev>,
Florian Westphal <fw@strlen•de>,
netdev@vger•kernel.org, eric.dumazet@gmail•com
Subject: Re: [PATCH net 0/5] mptcp: better validation of MPTCPOPT_MP_JOIN option
Date: Fri, 12 Jan 2024 10:53:36 -0800 (PST) [thread overview]
Message-ID: <fd09be5b-001a-8778-eef8-b49f10209967@kernel.org> (raw)
In-Reply-To: <20240111194917.4044654-1-edumazet@google.com>
On Thu, 11 Jan 2024, Eric Dumazet wrote:
> Based on a syzbot report (see 4th patch in the series).
>
> We need to be more explicit about which one of the
> following flag is set by mptcp_parse_option():
>
> - OPTION_MPTCP_MPJ_SYN
> - OPTION_MPTCP_MPJ_SYNACK
> - OPTION_MPTCP_MPJ_ACK
>
> Then select the appropriate values instead of OPTIONS_MPTCP_MPJ
>
> Paolo suggested to do the same for OPTIONS_MPTCP_MPC (5th patch)
>
> Eric Dumazet (5):
> mptcp: mptcp_parse_option() fix for MPTCPOPT_MP_JOIN
> mptcp: strict validation before using mp_opt->hmac
> mptcp: use OPTION_MPTCP_MPJ_SYNACK in subflow_finish_connect()
> mptcp: use OPTION_MPTCP_MPJ_SYN in subflow_check_req()
> mptcp: refine opt_mp_capable determination
>
> net/mptcp/options.c | 6 +++---
> net/mptcp/subflow.c | 16 ++++++++--------
> 2 files changed, 11 insertions(+), 11 deletions(-)
Hi Eric -
Thanks for the fixes, code looks good (one separate commit message
comment on patch 5):
Reviewed-by: Mat Martineau <martineau@kernel•org>
next prev parent reply other threads:[~2024-01-12 18:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 19:49 [PATCH net 0/5] mptcp: better validation of MPTCPOPT_MP_JOIN option Eric Dumazet
2024-01-11 19:49 ` [PATCH net 1/5] mptcp: mptcp_parse_option() fix for MPTCPOPT_MP_JOIN Eric Dumazet
2024-01-12 19:35 ` Simon Horman
2024-01-11 19:49 ` [PATCH net 2/5] mptcp: strict validation before using mp_opt->hmac Eric Dumazet
2024-01-12 19:36 ` Simon Horman
2024-01-11 19:49 ` [PATCH net 3/5] mptcp: use OPTION_MPTCP_MPJ_SYNACK in subflow_finish_connect() Eric Dumazet
2024-01-12 19:36 ` Simon Horman
2024-01-11 19:49 ` [PATCH net 4/5] mptcp: use OPTION_MPTCP_MPJ_SYN in subflow_check_req() Eric Dumazet
2024-01-12 19:37 ` Simon Horman
2024-01-11 19:49 ` [PATCH net 5/5] mptcp: refine opt_mp_capable determination Eric Dumazet
2024-01-12 18:58 ` Mat Martineau
2024-01-12 19:37 ` Simon Horman
2024-01-12 17:43 ` [PATCH net 0/5] mptcp: better validation of MPTCPOPT_MP_JOIN option Paolo Abeni
2024-01-12 18:53 ` Mat Martineau [this message]
2024-01-13 2:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd09be5b-001a-8778-eef8-b49f10209967@kernel.org \
--to=martineau@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=fw@strlen$(echo .)de \
--cc=geliang.tang@linux$(echo .)dev \
--cc=kuba@kernel$(echo .)org \
--cc=matttbe@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox