From: Brett Creeley <bcreeley@amd•com>
To: Jason Gunthorpe <jgg@nvidia•com>
Cc: "Tian, Kevin" <kevin.tian@intel•com>,
Brett Creeley <brett.creeley@amd•com>,
"kvm@vger•kernel.org" <kvm@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"alex.williamson@redhat•com" <alex.williamson@redhat•com>,
"yishaih@nvidia•com" <yishaih@nvidia•com>,
"shameerali.kolothum.thodi@huawei•com"
<shameerali.kolothum.thodi@huawei•com>,
"shannon.nelson@amd•com" <shannon.nelson@amd•com>
Subject: Re: [PATCH v12 vfio 3/7] vfio/pds: register with the pds_core PF
Date: Mon, 24 Jul 2023 11:20:42 -0700 [thread overview]
Message-ID: <fff62e3d-997a-69fc-fb2c-43ef9e7def30@amd.com> (raw)
In-Reply-To: <ZL516RPMMHS4Ds1k@nvidia.com>
On 7/24/2023 6:00 AM, Jason Gunthorpe wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> On Sat, Jul 22, 2023 at 12:09:58AM -0700, Brett Creeley wrote:
>> On 7/21/2023 2:01 AM, Tian, Kevin wrote:
>>> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>>>
>>>
>>>> From: Brett Creeley <brett.creeley@amd•com>
>>>> Sent: Thursday, July 20, 2023 6:35 AM
>>>>
>>>> +void pds_vfio_unregister_client_cmd(struct pds_vfio_pci_device *pds_vfio)
>>>> +{
>>>> + struct pci_dev *pdev = pds_vfio_to_pci_dev(pds_vfio);
>>>> + int err;
>>>> +
>>>> + err = pds_client_unregister(pci_physfn(pdev), pds_vfio->client_id);
>>>> + if (err)
>>>> + dev_err(&pdev->dev, "unregister from DSC failed: %pe\n",
>>>> + ERR_PTR(err));
>>>
>>> Why using ERR_PTR() here? it looks a common pattern used cross
>>> this series.
>>
>> Yes, this is intentional. This is more readable than just printing out the
>> error value.
>
> That seems like a hack, it would be nicer if printk could format
> errnos natively
This is already being used all over the driver hierarchy.
>
> Jason
next prev parent reply other threads:[~2023-07-24 18:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 22:35 [PATCH v12 vfio 0/7] pds-vfio-pci driver Brett Creeley
2023-07-19 22:35 ` [PATCH v12 vfio 1/7] vfio: Commonize combine_ranges for use in other VFIO drivers Brett Creeley
2023-07-21 8:51 ` Tian, Kevin
2023-07-22 7:05 ` Brett Creeley
2023-07-19 22:35 ` [PATCH v12 vfio 2/7] vfio/pds: Initial support for pds VFIO driver Brett Creeley
2023-07-21 8:53 ` Tian, Kevin
2023-07-22 7:06 ` Brett Creeley
2023-07-19 22:35 ` [PATCH v12 vfio 3/7] vfio/pds: register with the pds_core PF Brett Creeley
2023-07-21 9:01 ` Tian, Kevin
2023-07-22 7:09 ` Brett Creeley
2023-07-24 2:25 ` Tian, Kevin
2023-07-24 18:18 ` Brett Creeley
2023-07-24 13:00 ` Jason Gunthorpe
2023-07-24 18:20 ` Brett Creeley [this message]
2023-07-24 18:24 ` Jason Gunthorpe
2023-07-19 22:35 ` [PATCH v12 vfio 4/7] vfio/pds: Add VFIO live migration support Brett Creeley
2023-07-21 9:15 ` Tian, Kevin
2023-07-22 7:17 ` Brett Creeley
2023-07-24 2:30 ` Tian, Kevin
2023-07-24 12:58 ` Jason Gunthorpe
2023-07-24 21:39 ` Brett Creeley
2023-07-25 17:31 ` Simon Horman
2023-07-25 17:58 ` Brett Creeley
2023-07-19 22:35 ` [PATCH v12 vfio 5/7] vfio/pds: Add support for dirty page tracking Brett Creeley
2023-07-25 17:29 ` Simon Horman
2023-07-25 18:00 ` Brett Creeley
2023-07-19 22:35 ` [PATCH v12 vfio 6/7] vfio/pds: Add support for firmware recovery Brett Creeley
2023-07-19 22:35 ` [PATCH v12 vfio 7/7] vfio/pds: Add Kconfig and documentation Brett Creeley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fff62e3d-997a-69fc-fb2c-43ef9e7def30@amd.com \
--to=bcreeley@amd$(echo .)com \
--cc=alex.williamson@redhat$(echo .)com \
--cc=brett.creeley@amd$(echo .)com \
--cc=jgg@nvidia$(echo .)com \
--cc=kevin.tian@intel$(echo .)com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shameerali.kolothum.thodi@huawei$(echo .)com \
--cc=shannon.nelson@amd$(echo .)com \
--cc=yishaih@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox