Subject: Re: [PATCH net-next v2 01/11] net: rename netdev_ops_assert_locked()

From: Nicolai Buchwitz <[email-masked]>
Date: Wed, 03 Jun 2026 09:29:24 +0200

Hi Jakub

On 3.6.2026 03:28, Jakub Kicinski wrote:
> Jakub suggests renaming the existing assert to match
> the netdev_lock_ops_compat() semantics.
> 
> We want netdev_assert_locked_ops() to mean - if the driver
> is ops locked - check that it's holding the device lock.
> 
> The existing helper check for either ops lock or rtnl_lock,
> which is the locking behavior of netdev_lock_ops_compat().
> 
> The reason for naming divergence is likely that
> netdev_ops_assert_locked() predated the _compat() helpers.
> 
> Suggested-by: Jakub Sitnicki <[email-masked]>
> Signed-off-by: Jakub Kicinski <[email-masked]>
> ---

> [...]

Reviewed-by: Nicolai Buchwitz <[email-masked]>

Thanks
Nicolai