Subject: Re: [patch 4/5] s2io driver updates

From: Andreas Schwab <[email-masked]>
Date: Sun, 13 May 2007 15:22:13 +0200

Ananda Raju <[email-masked]> writes:

> @@ -2704,6 +2792,10 @@ static void tx_intr_handler(fifo_info_t 
>  		if (txdlp->Control_1 & TXD_T_CODE) {
>  			unsigned long long err;
>  			err = txdlp->Control_1 & TXD_T_CODE;
> +			if (err & 0x1) {

This is never true.

> @@ -5743,6 +6246,11 @@ static int rx_osm_handler(ring_info_t *r
>  	skb->dev = dev;
>  
>  	if (err) {
> +		/* Check for parity error */
> +		if (err & 0x1) {

Likewise.

(This is a very old patch, but the issue is still present.)

Andreas.

-- 
Andreas Schwab, SuSE Labs, [email-masked]
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."