Subject: Re: [PATCH net-next V4 08/13] bridge: Add netlink interface to configure vlans on bridge ports

From: Cong Wang <[email-masked]>
Date: Thu, 20 Dec 2012 07:48:55 +0000 (UTC)

On Wed, 19 Dec 2012 at 17:48 GMT, Vlad Yasevich <[email-masked]> wrote:
> diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
> index c30fe29..33bc740 100644
> --- a/net/bridge/br_if.c
> +++ b/net/bridge/br_if.c
> @@ -23,6 +23,7 @@
>  #include <linux/if_ether.h>
>  #include <linux/slab.h>
>  #include <net/sock.h>
> +#include <linux/if_vlan.h>

Huh??

>  
>  #include "br_private.h"
>  
> diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
> index dead9df..84c6f04 100644
> --- a/net/bridge/br_netlink.c
> +++ b/net/bridge/br_netlink.c
> @@ -16,6 +16,7 @@
>  #include <net/rtnetlink.h>
>  #include <net/net_namespace.h>
>  #include <net/sock.h>
> +#include <uapi/linux/if_bridge.h>
>  

Please don't include UAPI headers directly, you should #include
<linux/if_bridge.h>.