Subject: Re: [PATCH net-next 5/5] sock_diag: notify when filter change

From: Cong Wang <[email-masked]>
Date: Wed, 24 Apr 2013 08:05:15 +0000 (UTC)

On Tue, 23 Apr 2013 at 14:27 GMT, Nicolas Dichtel <[email-masked]> wrote:
> @@ -773,6 +775,7 @@ int sk_detach_filter(struct sock *sk)
>  		RCU_INIT_POINTER(sk->sk_filter, NULL);
>  		sk_filter_uncharge(sk, filter);
>  		ret = 0;
> +		sock_diag_notify(sk, 1);

Should be sock_diag_notify(sk, 0)?

BTW, use 'true' and 'false' instead of '1' and '0'.