public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail•com>
To: netdev@vger•kernel.org
Subject: Re: [PATCH net-next v3] ipv6: Kill ipv6 dependency of icmpv6_send().
Date: Mon, 29 Apr 2013 01:46:06 +0000 (UTC)	[thread overview]
Message-ID: <klkjcu$drc$1@ger.gmane.org> (raw)
In-Reply-To: 1366924110-3397-1-git-send-email-pshelar@nicira.com

On Thu, 25 Apr 2013 at 21:08 GMT, Pravin B Shelar <pshelar@nicira•com> wrote:
> diff --git a/net/ipv6/ip6_icmp.c b/net/ipv6/ip6_icmp.c
> new file mode 100644
> index 0000000..4578e23
> --- /dev/null
> +++ b/net/ipv6/ip6_icmp.c
> @@ -0,0 +1,47 @@
> +#include <linux/export.h>
> +#include <linux/icmpv6.h>
> +#include <linux/mutex.h>
> +#include <linux/netdevice.h>
> +#include <linux/spinlock.h>
> +
> +#include <net/ipv6.h>
> +
> +#if IS_ENABLED(CONFIG_IPV6)
> +

I don't think we need #if IS_ENABLED(CONFIG_IPV6) inside
net/ipv6/ip6_icmp.c.

  parent reply	other threads:[~2013-04-29  1:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-25 21:08 [PATCH net-next v3] ipv6: Kill ipv6 dependency of icmpv6_send() Pravin B Shelar
2013-04-25 22:48 ` Eric Dumazet
2013-04-29  1:46 ` Cong Wang [this message]
2013-04-29 17:44   ` Pravin Shelar
2013-04-29 17:55 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='klkjcu$drc$1@ger.gmane.org' \
    --to=xiyou.wangcong@gmail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox