Subject: Re: [PATCH nf-next] netfilter: conntrack: remove the central spinlock

From: Cong Wang <[email-masked]>
Date: Thu, 9 May 2013 07:46:52 +0000 (UTC)

On Thu, 09 May 2013 at 06:01 GMT, Eric Dumazet <[email-masked]> wrote:
> On Thu, 2013-05-09 at 05:43 +0000, Cong Wang wrote:
>> On Thu, 09 May 2013 at 03:04 GMT, Eric Dumazet <[email-masked]> wrote:
>> >  
>> > +#if 0
>> > +	for (i = 0; i < ARRAY_SIZE(nf_conntrack_locks); i++)
>> > +		arch_spin_lock_init(&nf_conntrack_locks[i]);
>> > +#endif
>> > +
>> 
>> Is this intentional?
>
> What do you think ?
>
> Apparently arch_spin_lock_init() does not exist (but for ia64)
>

Either it is not expected to use arch_spin_lock directly, or it has to
provide a nop for non-IA64.