From: Cong Wang <xiyou.wangcong@gmail•com>
To: netdev@vger•kernel.org
Subject: Re: [PATCH net-next v4 2/2] vxlan: allow specifying multiple default destinations
Date: Mon, 24 Jun 2013 06:48:17 +0000 (UTC) [thread overview]
Message-ID: <kq8q3h$9lu$1@ger.gmane.org> (raw)
In-Reply-To: 1372004543-24675-3-git-send-email-mike.rapoport@ravellosystems.com
On Sun, 23 Jun 2013 at 16:22 GMT, Mike Rapoport <mike.rapoport@ravellosystems•com> wrote:
> static int vxlan_validate(struct nlattr *tb[], struct nlattr *data[])
> {
> + int err;
> +
> if (tb[IFLA_ADDRESS]) {
> if (nla_len(tb[IFLA_ADDRESS]) != ETH_ALEN) {
> pr_debug("invalid link address (not ethernet)\n");
> @@ -1460,6 +1599,10 @@ static int vxlan_validate(struct nlattr *tb[], struct nlattr *data[])
> }
> }
>
> + err = vxlan_validate_remotes(data[IFLA_VXLAN_REMOTES]);
> + if (err)
> + return err;
> +
> return 0;
> }
Seems you can simply return vxlan_validate_remotes(...); here.
> +static int vxlan_fill_remotes_info(struct sk_buff *skb,
> + const struct vxlan_dev *vxlan)
> +{
> + struct vxlan_rdst *rd;
> + struct nlattr *nest, *rdst_nest;
> + __be32 ip;
> + int i = 1;
> +
> + if (!vxlan->remotes_cnt)
> + return 0;
> +
> + nest = nla_nest_start(skb, IFLA_VXLAN_REMOTES);
> + if (nest == NULL)
> + goto nla_put_failure;
> +
> + list_for_each_entry_rcu(rd, &vxlan->remotes, list) {
Need RCU read lock here?
> + ip = rd->remote_ip;
> +
> + if (ip == vxlan->default_dst.remote_ip)
> + continue;
> +
> + rdst_nest = nla_nest_start(skb, i);
> + if (rdst_nest == NULL)
> + goto nla_put_failure;
> +
> + if (nla_put_be32(skb, IFLA_VXLAN_REMOTE_ADDR, ip))
> + goto nla_put_failure;
> +
> + nla_nest_end(skb, rdst_nest);
> + i++;
> + }
> +
> + nla_nest_end(skb, nest);
> +
> + return 0;
> +
> +nla_put_failure:
> + return -EMSGSIZE;
> +}
> +
Thanks!
next prev parent reply other threads:[~2013-06-24 6:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-23 16:22 [PATCH net-next v4 0/2] vxlan: allow specifying multiple default destinations Mike Rapoport
2013-06-23 16:22 ` [PATCH net-next v4 1/2] vxlan: introduce vxlan_rdst_append Mike Rapoport
2013-06-24 6:02 ` Cong Wang
2013-06-24 6:54 ` Mike Rapoport
2013-06-24 8:28 ` David Miller
2013-06-24 7:21 ` Mike Rapoport
2013-06-23 16:22 ` [PATCH net-next v4 2/2] vxlan: allow specifying multiple default destinations Mike Rapoport
2013-06-24 0:14 ` Stephen Hemminger
2013-06-24 5:57 ` Mike Rapoport
2013-06-24 15:35 ` Stephen Hemminger
2013-06-24 19:52 ` Mike Rapoport
2013-06-24 20:24 ` Stephen Hemminger
2013-06-24 6:48 ` Cong Wang [this message]
2013-06-24 6:58 ` Mike Rapoport
2013-06-24 15:18 ` Stephen Hemminger
2013-06-23 16:24 ` [PATCH iproute2 1/2] vxlan: introduce vxlan_parse_opt_create Mike Rapoport
2013-06-23 16:24 ` [PATCH iproute2 2/2] vxlan: allow specifying multiple default destinations Mike Rapoport
2013-06-24 0:32 ` Cong Wang
2013-06-24 5:40 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='kq8q3h$9lu$1@ger.gmane.org' \
--to=xiyou.wangcong@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox