From: ebiederm@xmission•com (Eric W. Biederman)
To: Basil Gor <basil.gor@gmail•com>
Cc: "David S. Miller" <davem@davemloft•net>, netdev@vger•kernel.org
Subject: Re: [PATCH v3 2/2] macvtap: restore vlan header on user read
Date: Wed, 25 Apr 2012 22:31:25 -0700 [thread overview]
Message-ID: <m162cngitu.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <1335373316-612-1-git-send-email-basil.gor@gmail.com> (Basil Gor's message of "Wed, 25 Apr 2012 21:01:56 +0400")
Basil Gor <basil.gor@gmail•com> writes:
> Vlan tag is restored during buffer transmit to a network device (bridge
> port) in bridging code in case of tun/tap driver. In case of macvtap it
> has to be done explicitly. Otherwise vlan_tci is ignored and user always
> gets untagged packets.
We could quibble about efficiencies but this looks good except for
macvtap_recvmsg which isn't setting the auxdata for the vlan header.
Eric
> Signed-off-by: Basil Gor <basil.gor@gmail•com>
> ---
> drivers/net/macvtap.c | 11 ++++++++++-
> 1 files changed, 10 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
> index 0427c65..28d2678 100644
> --- a/drivers/net/macvtap.c
> +++ b/drivers/net/macvtap.c
> @@ -1,6 +1,7 @@
> #include <linux/etherdevice.h>
> #include <linux/if_macvlan.h>
> #include <linux/interrupt.h>
> +#include <linux/if_vlan.h>
> #include <linux/nsproxy.h>
> #include <linux/compat.h>
> #include <linux/if_tun.h>
> @@ -753,13 +754,21 @@ static ssize_t macvtap_aio_write(struct kiocb *iocb, const struct iovec *iv,
>
> /* Put packet to the user space buffer */
> static ssize_t macvtap_put_user(struct macvtap_queue *q,
> - const struct sk_buff *skb,
> + struct sk_buff *skb,
> const struct iovec *iv, int len)
> {
> struct macvlan_dev *vlan;
> int ret;
> int vnet_hdr_len = 0;
>
> + if (vlan_tx_tag_present(skb)) {
> + skb = __vlan_put_tag(skb, vlan_tx_tag_get(skb));
> + if (unlikely(!skb))
> + return -ENOMEM;
> +
> + skb->vlan_tci = 0;
> + }
> +
> if (q->flags & IFF_VNET_HDR) {
> struct virtio_net_hdr vnet_hdr;
> vnet_hdr_len = q->vnet_hdr_sz;
next prev parent reply other threads:[~2012-04-26 5:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 18:34 [PATCH] macvlan/macvtap: Fix vlan tagging on user read Basil Gor
2012-04-18 18:54 ` Eric W. Biederman
2012-04-18 19:33 ` Basil Gor
2012-04-20 23:11 ` Basil Gor
2012-04-21 1:49 ` Eric W. Biederman
2012-04-25 17:01 ` [PATCH v3 1/2] vhost-net: fix handle_rx buffer size Basil Gor
2012-04-26 5:30 ` Eric W. Biederman
2012-05-03 12:39 ` Michael S. Tsirkin
2012-05-03 13:16 ` Michael S. Tsirkin
2012-05-03 14:43 ` Basil Gor
2012-04-25 17:01 ` [PATCH v3 2/2] macvtap: restore vlan header on user read Basil Gor
2012-04-26 5:31 ` Eric W. Biederman [this message]
2012-05-03 13:07 ` Michael S. Tsirkin
2012-05-03 13:37 ` Eric W. Biederman
2012-05-03 14:31 ` Michael S. Tsirkin
2012-05-03 15:22 ` Basil Gor
2012-05-03 23:11 ` Basil Gor
2012-05-03 23:30 ` Michael S. Tsirkin
2012-05-03 23:47 ` Basil Gor
2012-05-04 1:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m162cngitu.fsf@fess.ebiederm.org \
--to=ebiederm@xmission$(echo .)com \
--cc=basil.gor@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox