Subject: Re: [PATCH 5/6] bond: Implement a basic set of rtnl link ops

From: [email-masked] (Eric W. Biederman)
Date: Fri, 30 Oct 2009 02:23:31 -0700

Patrick McHardy <[email-masked]> writes:

> Eric W. Biederman wrote:
>> +static struct rtnl_link_ops bond_link_ops __read_mostly = {
>> +	.kind		= "bond",
>> +	.setup		= bond_setup,
>> +	.validate	= bond_validate,
>> +};
>
> One more thing - you need to initialize .priv_size here so
> the devices created through rtnl_link have enough private
> room allocated.

Wow and the code works when I test it without that ouch!

As for rtnl_link_register it always succeeds so let's just
remove the return code and call it good.

Eric