From: ebiederm@xmission•com (Eric W. Biederman)
To: Stephen Hemminger <shemminger@vyatta•com>
Cc: Brian Haley <brian.haley@hp•com>,
David Miller <davem@davemloft•net>,
netdev@vger•kernel.org, Mahesh Kelkar <maheshkelkar@gmail•com>,
Lorenzo Colitti <lorenzo@google•com>,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6•org>,
stable@kernel•org
Subject: Re: [PATCH] Fix 2.6.34-rc1 regression in disable_ipv6 support
Date: Thu, 09 Dec 2010 11:22:56 -0800 [thread overview]
Message-ID: <m1ipz2699r.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <20101209082703.6e5519e7@nehalam> (Stephen Hemminger's message of "Thu, 9 Dec 2010 08:27:03 -0800")
Stephen Hemminger <shemminger@vyatta•com> writes:
> On Thu, 09 Dec 2010 10:28:10 -0500
> Brian Haley <brian.haley@hp•com> wrote:
>
>> On 12/08/2010 11:16 PM, Eric W. Biederman wrote:
>> /* If just doing link down, and address is permanent
>> and not link-local, then retain it. */
>> if (!how &&
>> (ifa->flags&IFA_F_PERMANENT) &&
>> !(ipv6_addr_type(&ifa->addr) & IPV6_ADDR_LINKLOCAL)) {
>> list_move_tail(&ifa->if_list, &keep_list);
>>
>> /* If not doing DAD on this address, just keep it. */
>> if ((dev->flags&(IFF_NOARP|IFF_LOOPBACK)) ||
>> idev->cnf.accept_dad <= 0 ||
>> (ifa->flags & IFA_F_NODAD))
>
> I think the problem is on coming back up, not on the down step.
Oh it is. All addresses that you keep break if you down the loopback
interface, no matter which interface those addresses are on.
Stephen the cause of the regression in 2.6.34-rc1 that you introduced
that breaks the disable_ipv6 functionality in practice is removing
the loopback address from the loopback interface. So I sent
a partial revert.
It is safe to do a partial revert because the loopback address is always
reprogrammed when we bring the interface back up. But that
reprogramming only works if it doesn't error out with -EEXIST.
So by all means properly fix the ancient bug that breaks usage of all
local ipv6 addresses when the loopback interface is brought down,
and we can remove the regression fix.
However complaining about a partial revert to fix a regression you
introduced because it fixes a problem deep within the ipv6 networking
stack that the smallest modicum of testing would have revealed on your
part before you broke things seems inappropriate.
Please let's get the disable_ipv6 functionality working again (where
in practice we don't care about preserving addresses). Then let's
take our time and tack and fix whatever this is properly.
Eric
next prev parent reply other threads:[~2010-12-09 19:23 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 0:24 echo > 0 .../disable_ipv6 broken in 2.6.37-rc4 Eric W. Biederman
2010-12-06 0:33 ` Lorenzo Colitti
2010-12-06 0:39 ` Eric W. Biederman
2010-12-06 5:51 ` Eric W. Biederman
2010-12-06 16:10 ` Brian Haley
2010-12-08 21:29 ` Eric W. Biederman
2010-12-08 22:49 ` Brian Haley
2010-12-08 23:13 ` Eric W. Biederman
2010-12-08 23:49 ` Stephen Hemminger
2010-12-09 2:42 ` Eric W. Biederman
2010-12-09 3:18 ` Eric W. Biederman
2010-12-09 4:16 ` [PATCH] Fix 2.6.34-rc1 regression in disable_ipv6 support Eric W. Biederman
2010-12-09 15:28 ` Brian Haley
2010-12-09 16:27 ` Stephen Hemminger
2010-12-09 19:22 ` Eric W. Biederman [this message]
2010-12-09 19:09 ` Eric W. Biederman
2010-12-09 19:16 ` Stephen Hemminger
2010-12-09 19:31 ` Eric W. Biederman
2010-12-09 20:20 ` David Miller
2010-12-09 20:20 ` David Miller
2010-12-09 22:51 ` Stephen Hemminger
2010-12-16 21:28 ` [RFC] ipv6: don't flush routes when setting loopback down Stephen Hemminger
2010-12-16 23:17 ` Eric W. Biederman
2010-12-17 1:18 ` Eric W. Biederman
2010-12-17 2:26 ` David Miller
2011-01-19 19:18 ` Jiri Bohac
2011-01-19 19:38 ` Stephen Hemminger
2011-01-19 19:56 ` Jiri Bohac
2011-01-19 20:01 ` Stephen Hemminger
2011-01-22 8:17 ` Eric W. Biederman
2011-01-22 22:39 ` Stephen Hemminger
2011-01-22 22:54 ` David Miller
2011-01-23 4:41 ` Stephen Hemminger
2011-01-23 5:42 ` David Miller
2011-01-23 8:24 ` Stephen Hemminger
2011-01-23 8:26 ` Stephen Hemminger
2011-01-23 9:15 ` [stable] " Willy Tarreau
2011-01-23 9:21 ` Stephen Hemminger
2011-01-23 10:34 ` Stephen Hemminger
2011-01-23 19:21 ` Eric W. Biederman
2011-01-23 19:57 ` [stable] " David Miller
2011-01-23 19:48 ` David Miller
2011-01-23 19:47 ` David Miller
2010-12-10 4:02 ` [PATCH] Fix 2.6.34-rc1 regression in disable_ipv6 support Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1ipz2699r.fsf@fess.ebiederm.org \
--to=ebiederm@xmission$(echo .)com \
--cc=brian.haley@hp$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=lorenzo@google$(echo .)com \
--cc=maheshkelkar@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shemminger@vyatta$(echo .)com \
--cc=stable@kernel$(echo .)org \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox