From: ebiederm@xmission•com (Eric W. Biederman)
To: David Miller <davem@davemloft•net>
Cc: jpirko@redhat•com, netdev@vger•kernel.org
Subject: Re: [PATCH net-next-2.6] netns: call ops_free right after ops_exit
Date: Sun, 25 Apr 2010 07:50:34 -0700 [thread overview]
Message-ID: <m1k4rvvb5x.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <20100425.025902.94572342.davem@davemloft.net> (David Miller's message of "Sun\, 25 Apr 2010 02\:59\:02 -0700 \(PDT\)")
David Miller <davem@davemloft•net> writes:
> From: Jiri Pirko <jpirko@redhat•com>
> Date: Sun, 25 Apr 2010 11:26:01 +0200
>
>> There's no need to iterate this twice. We can free net generic
>> variables right after exit is called.
>>
>> Signed-off-by: Jiri Pirko <jpirko@redhat•com>
>
> Are you sure there are no problems with doing this?
>
> What if there are inter-net variable reference dependencies
> or something like that?
>
> I really suspect it is being done this way on purpose, but
> in the end I defer to experts like Eric B. :-)
I am pretty certain there is a problem. My memory is fuzzy this
morning but I believe we can have rcu references between various
pieces of the networking stack for a single network namespace. So we
need to cause all of the network namespace to exit before it is safe
to free those pieces.
Eric
next prev parent reply other threads:[~2010-04-25 14:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-25 9:26 [PATCH net-next-2.6] netns: call ops_free right after ops_exit Jiri Pirko
2010-04-25 9:59 ` David Miller
2010-04-25 14:50 ` Eric W. Biederman [this message]
2010-04-25 18:44 ` Jiri Pirko
2010-04-26 3:06 ` Eric W. Biederman
2010-04-26 10:43 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1k4rvvb5x.fsf@fess.ebiederm.org \
--to=ebiederm@xmission$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jpirko@redhat$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox