From: ebiederm@xmission•com (Eric W. Biederman)
To: Jay Vosburgh <fubar@us•ibm.com>
Cc: David Miller <davem@davemloft•net>, netdev@vger•kernel.org
Subject: Re: [PATCH 0/6] Bonding simplifications and netns support
Date: Fri, 30 Oct 2009 18:06:00 -0700 [thread overview]
Message-ID: <m1ljisid8n.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <32609.1256947853@death.nxdomain.ibm.com> (Jay Vosburgh's message of "Fri\, 30 Oct 2009 17\:10\:53 -0700")
Jay Vosburgh <fubar@us•ibm.com> writes:
> No, to both questions. Also, if I back out the 7 bonding
> patches, the same insmod / rmmod does not panic.
>
> I just set it up and did it again. Fresh boot of the system
> (which doesn't load bonding); "insmod drivers/net/bonding/bonding.ko;
> rmmod bonding" and blammo.
>
> A little bisect action reveals that the problem first appears
> after applying the fifth patch (below). Does a basic insmod / rmmod
> cycle work ok for you? I'm specifying no options to bonding.
It works here. The only issue I found was that veth wasn't quite
working. I am wondering if there was some version of the tree
where rtnl_link_unregister is broken and you applied the patches to that.
I tested the net-next tree with my patches at the top:
There are some other differences like I am running a 64bit kernel but
I don't expect that would make a difference in practice.
Eric
commit 6639104bd826e0b1388c69a6b7564fffc636c8a8
Author: Eric W. Biederman <ebiederm@xmission•com>
Date: Thu Oct 29 23:58:54 2009 +0000
bond: Get the rtnl_link_ops support correct
- Don't call rtnl_link_unregister if rtnl_link_register fails
- Set .priv_size so we aren't stomping on uninitialized memory
when we use netdev_priv, on bond devices created with
ip link add type bond.
Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks•com>
Signed-off-by: David S. Miller <davem@davemloft•net>
next prev parent reply other threads:[~2009-10-31 1:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-30 0:16 [PATCH 0/6] Bonding simplifications and netns support Eric W. Biederman
2009-10-30 0:18 ` [PATCH 1/6] net: Allow devices to specify a device specific sysfs group Eric W. Biederman
2009-10-30 0:18 ` [PATCH 2/6] bond: Simply bond sysfs group creation Eric W. Biederman
2009-10-30 0:18 ` [PATCH 3/6] bond: Simplify bond_create Eric W. Biederman
2009-10-30 0:18 ` [PATCH 4/6] bond: Simplify bond device destruction Eric W. Biederman
2009-10-30 0:18 ` [PATCH 5/6] bond: Implement a basic set of rtnl link ops Eric W. Biederman
2009-10-30 8:06 ` Patrick McHardy
2009-10-30 8:29 ` Patrick McHardy
2009-10-30 9:23 ` Eric W. Biederman
2009-10-30 9:33 ` Patrick McHardy
2009-10-30 9:58 ` [PATCH 7/6] bond: Get the rtnl_link_ops support correct Eric W. Biederman
2009-10-30 10:00 ` [PATCH 5/6] bond: Implement a basic set of rtnl link ops Eric W. Biederman
2009-10-30 10:08 ` Patrick McHardy
2009-10-30 0:18 ` [PATCH 6/6] bond: Add support for multiple network namespaces Eric W. Biederman
2009-10-30 6:25 ` [PATCH 0/6] Bonding simplifications and netns support David Miller
2009-10-30 6:38 ` Eric Dumazet
2009-10-30 6:40 ` David Miller
2009-10-30 7:50 ` Eric W. Biederman
2009-10-30 10:39 ` Eric W. Biederman
2009-10-30 19:41 ` David Miller
2009-10-30 21:12 ` Jay Vosburgh
2009-10-30 22:57 ` Eric W. Biederman
2009-10-31 0:10 ` Jay Vosburgh
2009-10-31 1:06 ` Eric W. Biederman [this message]
2009-10-31 1:45 ` Jay Vosburgh
2009-10-31 0:27 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1ljisid8n.fsf@fess.ebiederm.org \
--to=ebiederm@xmission$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=fubar@us$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox