Subject: Re: [PATCH 2.6.25] net: removes unnecessary dependencies for net_namespace.h

From: [email-masked] (Eric W. Biederman)
Date: Mon, 03 Dec 2007 04:56:01 -0700

"Denis V. Lunev" <[email-masked]> writes:

> This patch removes some unneeded includes for net_namespace.h to speed up
> compilation.
>
> Signed-off-by: Denis V. Lunev <[email-masked]>
>
> diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h
> index f285de6..28b7f25 100644
> --- a/include/net/pkt_cls.h
> +++ b/include/net/pkt_cls.h
> @@ -2,7 +2,6 @@
>  #define __NET_PKT_CLS_H
>  
>  #include <linux/pkt_cls.h>
> -#include <net/net_namespace.h>
>  #include <net/sch_generic.h>
>  #include <net/act_api.h>

What of tcf_match_indev?  I guess linux/netdevice.h brings
it in for us but still.

> diff --git a/include/net/sock.h b/include/net/sock.h
> index 43e3cd9..a04e361 100644
> --- a/include/net/sock.h
> +++ b/include/net/sock.h
> @@ -57,7 +57,6 @@
>  #include <asm/atomic.h>
>  #include <net/dst.h>
>  #include <net/checksum.h>
> -#include <net/net_namespace.h>
>  
>  /*
>   * This structure really needs to be cleaned up.
> @@ -95,6 +94,7 @@ typedef struct {
>  
>  struct sock;
>  struct proto;
> +struct net;
>  
>  /**
>   *	struct sock_common - minimal network layer representation of sockets

This hunk definitely looks sane.

Eric