From: ebiederm@xmission•com (Eric W. Biederman)
To: Gao feng <gaofeng@cn•fujitsu.com>
Cc: David Miller <davem@davemloft•net>,
netdev@vger•kernel.org, "Serge E. Hallyn" <serge@hallyn•com>,
pablo@netfilter•org, Stephen Hemminger <shemminger@vyatta•com>,
Pavel Emelyanov <xemul@openvz•org>
Subject: Re: [PATCH net-next 05/19] net: Move all of the network sysctls without a namespace into init_net.
Date: Sun, 22 Apr 2012 18:50:42 -0700 [thread overview]
Message-ID: <m1sjfvtdvx.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <4F94A494.7020006@cn.fujitsu.com> (Gao feng's message of "Mon, 23 Apr 2012 08:38:44 +0800")
Gao feng <gaofeng@cn•fujitsu.com> writes:
> 于 2012年04月20日 07:24, Eric W. Biederman 写道:
>>
>> This makes it clearer which sysctls are relative to your current network
>> namespace.
>>
>> This makes it a little less error prone by not exposing sysctls for the
>> initial network namespace in other namespaces.
>>
>> This is the same way we handle all of our other network interfaces to
>> userspace and I can't honestly remember why we didn't do this for
>> sysctls right from the start.
>>
>> Signed-off-by: Eric W. Biederman <ebiederm@xmission•com>
>> ---
>> drivers/infiniband/core/ucma.c | 4 ++--
>> net/802/tr.c | 2 +-
>> net/appletalk/sysctl_net_atalk.c | 4 ++--
>> net/ax25/sysctl_net_ax25.c | 4 ++--
>> net/bridge/br_netfilter.c | 4 ++--
>> net/core/neighbour.c | 2 +-
>> net/core/sysctl_net_core.c | 2 +-
>> net/dccp/sysctl.c | 4 ++--
>> net/decnet/dn_dev.c | 4 ++--
>> net/decnet/sysctl_net_decnet.c | 4 ++--
>> net/ipv4/netfilter/ip_queue.c | 6 +++---
>> net/ipv4/route.c | 2 +-
>> net/ipv4/sysctl_net_ipv4.c | 4 ++--
>> net/ipv6/netfilter/ip6_queue.c | 6 +++---
>> net/ipv6/netfilter/nf_conntrack_reasm.c | 4 ++--
>> net/ipv6/sysctl_net_ipv6.c | 2 +-
>> net/ipx/sysctl_net_ipx.c | 5 +++--
>> net/irda/irsysctl.c | 4 ++--
>> net/llc/sysctl_net_llc.c | 5 +++--
>> net/netfilter/nf_conntrack_proto.c | 4 ++--
>
> Hi Eric
>
> actually,I'm working on making the sysctl and data of nf_conntrack proto pernet,
> and I think it's necessary,without the pernet proto timeout,we can't control
> the container's conntrack timeout unless we change the host's timeout.
>
> maybe somebody want the conntracks in container expired quickly.
> So I will keep on doing this job base on your patchset.
>
> what's your comment?
My quick skim of your patches suggested to me you are doing useful work.
Making sysctls that are not pernet init_net only serve two
purposes.
- Prevent mistakes by changing a sysctl you think is pernet but globally
affects the networking stack.
- Make it easy to find which sysctls need to be converted.
I suspect a lot of sysctls have not been converted simply because no one
realized they had not been converted.
I hope my code cleanup did not set you back very much. I don't believe
there were any conflicts in principle just a few places where we touched
the same code.
Eric
next prev parent reply other threads:[~2012-04-23 1:46 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 23:17 [PATCH net-next 00/19] net: Sysctl simplifications and enhancements Eric W. Biederman
2012-04-19 23:18 ` [PATCH net-next 01/19] net: Implement register_net_sysctl Eric W. Biederman
2012-04-20 5:27 ` Pavel Emelyanov
2012-04-20 8:11 ` Eric W. Biederman
2012-04-20 8:45 ` Pavel Emelyanov
2012-04-19 23:19 ` [PATCH net-next 02/19] net sysctl: Register an empty /proc/sys/net Eric W. Biederman
2012-04-19 23:20 ` [PATCH net-next 03/19] net sysctl: Initialize the network sysctls sooner to avoid problems Eric W. Biederman
2012-04-19 23:22 ` [PATCH net-next 04/19] net: Kill register_sysctl_rotable Eric W. Biederman
2012-04-20 13:53 ` Serge E. Hallyn
2012-04-20 14:42 ` Eric W. Biederman
2012-04-19 23:24 ` [PATCH net-next 05/19] net: Move all of the network sysctls without a namespace into init_net Eric W. Biederman
2012-04-23 0:38 ` Gao feng
2012-04-23 1:50 ` Eric W. Biederman [this message]
2012-04-23 2:29 ` Gao feng
2012-04-19 23:25 ` [PATCH net-next 06/19] net core: Remove unneded creation of an empty net/core sysctl directory Eric W. Biederman
2012-04-19 23:26 ` [PATCH net-next 07/19] net ipv6: Remove unneded registration of an empty net/ipv6/neigh Eric W. Biederman
2012-04-19 23:32 ` [PATCH net-next 08/19] net ipv4: Remove the unneeded registration of an empty net/ipv4/neigh Eric W. Biederman
2012-04-19 23:34 ` [PATCH net-next 09/19] net ax25: Simplify and cleanup the ax25 sysctl handling Eric W. Biederman
2012-04-19 23:35 ` [PATCH net-next 10/19] net llc: Don't use sysctl tables with .child entries Eric W. Biederman
2012-04-19 23:37 ` [PATCH net-next 11/19] net ipv6: " Eric W. Biederman
2012-04-19 23:38 ` [PATCH net-next 12/19] net neighbour: Convert to use register_net_sysctl Eric W. Biederman
2012-04-20 5:21 ` Pavel Emelyanov
2012-04-20 7:25 ` Eric W. Biederman
2012-04-22 2:36 ` Ben Hutchings
2012-04-19 23:40 ` [PATCH net-next 13/19] net decnet: " Eric W. Biederman
2012-04-19 23:41 ` [PATCH net-next 14/19] net ipv6: Convert addrconf " Eric W. Biederman
2012-04-19 23:42 ` [PATCH net-next 15/19] net ipv4: Convert devinet " Eric W. Biederman
2012-04-19 23:43 ` [PATCH net-next 16/19] net: Convert nf_conntrack_proto " Eric W. Biederman
2012-04-19 23:44 ` [PATCH net-next 17/19] net: Convert all sysctl registrations to register_net_sysctl Eric W. Biederman
2012-04-19 23:45 ` [PATCH net-next 18/19] net: Delete all remaining instances of ctl_path Eric W. Biederman
2012-04-19 23:46 ` [PATCH net-next 19/19] net: Remove register_net_sysctl_table Eric W. Biederman
2012-04-20 8:45 ` [PATCH net-next 00/19] net: Sysctl simplifications and enhancements Pavel Emelyanov
2012-04-21 1:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1sjfvtdvx.fsf@fess.ebiederm.org \
--to=ebiederm@xmission$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gaofeng@cn$(echo .)fujitsu.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pablo@netfilter$(echo .)org \
--cc=serge@hallyn$(echo .)com \
--cc=shemminger@vyatta$(echo .)com \
--cc=xemul@openvz$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox