From: ebiederm@xmission•com (Eric W. Biederman)
To: David Miller <davem@davemloft•net>
Cc: netdev@vger•kernel.org, kaber@trash•net,
David Lamparter <equinox@diac24•net>,
Renato Westphal <renatowestphal@gmail•com>,
Patrick McHardy <kaber@trash•net>
Subject: [PATCH] rtnetlink: Add missing manual netlink notification in dev_change_net_namespaces
Date: Fri, 21 Oct 2011 09:24:20 -0700 [thread overview]
Message-ID: <m1ty72l3d7.fsf_-_@fess.ebiederm.org> (raw)
In-Reply-To: <CAChaegnHchLT0BV-_RaPT2-J3ZLin_U1x8X0KBi7ku1MArug1g@mail.gmail.com> (Renato Westphal's message of "Fri, 19 Aug 2011 11:38:33 -0300")
Renato Westphal noticed that since commit a2835763e130c343ace5320c20d33c281e7097b7
"rtnetlink: handle rtnl_link netlink notifications manually" was merged
we no longer send a netlink message when a networking device is moved
from one network namespace to another.
Fix this by adding the missing manual notification in dev_change_net_namespaces.
Since all network devices that are processed by dev_change_net_namspaces are
in the initialized state the complicated tests that guard the manual
rtmsg_ifinfo calls in rollback_registered and register_netdevice are
unnecessary and we can just perform a plain notification.
Cc: stable@kernel•org
Tested-by: Renato Westphal <renatowestphal@gmail•com>
Signed-off-by: Eric W. Biederman <ebiederm@xmission•com>
---
net/core/dev.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index ad5d702..b7ba81a 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -6266,6 +6266,7 @@ int dev_change_net_namespace(struct net_device *dev, struct net *net, const char
*/
call_netdevice_notifiers(NETDEV_UNREGISTER, dev);
call_netdevice_notifiers(NETDEV_UNREGISTER_BATCH, dev);
+ rtmsg_ifinfo(RTM_DELLINK, dev, ~0U);
/*
* Flush the unicast and multicast chains
--
1.7.2.5
next prev parent reply other threads:[~2011-10-21 16:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 0:31 Move interface across network namespaces Renato Westphal
2011-08-11 7:13 ` Eric W. Biederman
2011-08-11 18:29 ` Renato Westphal
2011-08-15 13:10 ` Renato Westphal
2011-08-18 23:12 ` Eric W. Biederman
2011-08-19 14:38 ` Renato Westphal
2011-10-21 16:24 ` Eric W. Biederman [this message]
2011-10-24 7:03 ` [PATCH] rtnetlink: Add missing manual netlink notification in dev_change_net_namespaces David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1ty72l3d7.fsf_-_@fess.ebiederm.org \
--to=ebiederm@xmission$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=equinox@diac24$(echo .)net \
--cc=kaber@trash$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=renatowestphal@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox