From: ebiederm@xmission•com (Eric W. Biederman)
To: Benjamin Thery <benjamin.thery@bull•net>
Cc: "Serge E. Hallyn" <serue@us•ibm.com>,
netdev <netdev@vger•kernel.org>,
Dave Miller <davem@davemloft•net>,
Greg Kroah-Hartman <gregkh@suse•de>,
Al Viro <viro@ftp•linux.org.uk>,
Daniel Lezcano <dlezcano@fr•ibm.com>,
linux-kernel@vger•kernel.org, Tejun Heo <htejun@gmail•com>,
Denis Lunev <den@openvz•org>,
Linux Containers <containers@lists•linux-foundation.org>
Subject: Re: [PATCH] netns: Coexist with the sysfs limitations
Date: Thu, 23 Oct 2008 08:40:09 -0700 [thread overview]
Message-ID: <m1tzb3iali.fsf@frodo.ebiederm.org> (raw)
In-Reply-To: <49003019.40904@bull.net> (Benjamin Thery's message of "Thu, 23 Oct 2008 10:04:41 +0200")
Benjamin Thery <benjamin.thery@bull•net> writes:
> Serge E. Hallyn wrote:
>> Quoting Eric W. Biederman (ebiederm@xmission•com):
>>> To make testing of the network namespace simpler allow
>>> the network namespace code and the sysfs code to be
>>> compiled and run at the same time. To do this only
>>> virtual devices are allowed in the additional network
>>> namespaces and those virtual devices are not placed
>>> in the kobject tree.
>>>
>>> Since virtual devices don't actually do anything interesting
>>> hardware wise that needs device management there should
>>> be no loss in keeping them out of the kobject tree and
>>> by implication sysfs. The gain in ease of testing
>>> and code coverage should be significant.
>>>
>>> I.e. people running distributions that make it next to
>>> impossible to boot without sysfs should at be able to
>>> boot a test kernel now.
>>>
>>> Plus no ABIs are harmed with this patch.
>
>>> Signed-off-by: Eric W. Biederman <ebiederm@xmission•com>
>>
>> Duh.
>>
>> Tested-by: Serge Hallyn <serue@us•ibm.com>
>> Acked-by: Serge Hallyn <serue@us•ibm.com>
>
> Oh, this patch is short, clean, and the limitation introduced isn't too
> annoying for testing netns right now.
>
> At least, my proposal provoked some reactions :)
Yes.
> BTW, there's a second limitation with your patch:
> we can't rename the net devices in the additional network namespaces.
>
> In net/core/dev.c, dev_change_name() fails: call to device_rename() return an
> (expected) -EINVAL error.
> Maybe we should add a test on the net to only call it in init_net?
Yes. Good catch.
Eric
next prev parent reply other threads:[~2008-10-23 15:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 15:21 [PATCH 0/4][RFC] netns: sysfs: add a netns suffix to net device sysfs entries Benjamin Thery
2008-10-22 15:21 ` [PATCH 1/4] netns: add in ida ID to identify the network namespace Benjamin Thery
2008-10-22 15:22 ` [PATCH 2/4] netns: Export nets id to /proc/net/netns Benjamin Thery
2008-10-22 15:22 ` [PATCH 3/4] net: cleanup some vars names to be more consistant with the network code Benjamin Thery
2008-10-22 15:22 ` [PATCH 4/4] netns: sysfs: add netns suffix to net devices sysfs entries Benjamin Thery
2008-10-22 19:59 ` [PATCH 0/4][RFC] netns: sysfs: add a netns suffix to net device " Eric W. Biederman
2008-10-22 20:30 ` Serge E. Hallyn
2008-10-22 21:01 ` Eric W. Biederman
2008-10-22 21:55 ` Stephen Hemminger
2008-10-22 22:54 ` Eric W. Biederman
2008-10-23 4:14 ` Kyle Moffett
2008-10-23 11:56 ` Benjamin Thery
2008-10-23 15:46 ` Eric W. Biederman
2008-10-22 20:16 ` Greg KH
2008-10-22 21:08 ` Eric W. Biederman
2008-10-22 21:24 ` Greg KH
2008-10-22 20:32 ` [PATCH] netns: Coexist with the sysfs limitations Eric W. Biederman
2008-10-22 20:40 ` Daniel Lezcano
2008-10-22 21:21 ` Serge E. Hallyn
2008-10-23 8:04 ` Benjamin Thery
2008-10-23 15:40 ` Eric W. Biederman [this message]
2008-10-23 15:56 ` [PATCH] netns: Coexist with the sysfs limitations v2 Eric W. Biederman
2008-10-27 19:41 ` David Miller
2008-10-27 20:19 ` Eric W. Biederman
2008-10-28 0:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1tzb3iali.fsf@frodo.ebiederm.org \
--to=ebiederm@xmission$(echo .)com \
--cc=benjamin.thery@bull$(echo .)net \
--cc=containers@lists$(echo .)linux-foundation.org \
--cc=davem@davemloft$(echo .)net \
--cc=den@openvz$(echo .)org \
--cc=dlezcano@fr$(echo .)ibm.com \
--cc=gregkh@suse$(echo .)de \
--cc=htejun@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=serue@us$(echo .)ibm.com \
--cc=viro@ftp$(echo .)linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox