Subject: Re: [net-next 02/11] igb: Use node specific allocations for the q_vectors and rings

From: Andi Kleen <[email-masked]>
Date: Sun, 09 Oct 2011 11:08:47 -0700

Jeff Kirsher <[email-masked]> writes:
>  
>  	for (i = 0; i < adapter->num_tx_queues; i++) {
> -		ring = kzalloc(sizeof(struct igb_ring), GFP_KERNEL);
> +		if (orig_node == -1) {
> +			int cur_node = next_online_node(adapter->node);
> +			if (cur_node == MAX_NUMNODES)
> +				cur_node = first_online_node;

RR seems quite arbitrary. Who guarantees those nodes have any
relationship with the CPUs submitting on those queues? Or the node
the device is on.

Anyways if it's a good idea probably need to add a
dma_alloc_coherent_node() too

-Andi

-- 
[email-masked] -- Speaking for myself only