From: Christian Hopps <chopps@chopps•org>
To: Paul Wouters <paul@nohats•ca>
Cc: Leon Romanovsky <leon@kernel•org>,
Antony Antony <antony.antony@secunet•com>,
Steffen Klassert <steffen.klassert@secunet•com>,
Herbert Xu <herbert@gondor•apana.org.au>,
netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Eyal Birger <eyal.birger@gmail•com>,
Nicolas Dichtel <nicolas.dichtel@6wind•com>,
Sabrina Dubroca <sd@queasysnail•net>,
devel@linux-ipsec•org
Subject: Re: [devel-ipsec] [PATCH ipsec-next v10 1/3] xfrm: Add Direction to the SA in or out
Date: Thu, 11 Apr 2024 12:40:30 -0400 [thread overview]
Message-ID: <m24jc7lt50.fsf@chopps.org> (raw)
In-Reply-To: <549D487E-8B20-439C-93EB-85E0B3C9A2D7@nohats.ca>
Paul Wouters via Devel <devel@linux-ipsec•org> writes:
> On Apr 11, 2024, at 07:41, Leon Romanovsky via Devel <devel@linux-ipsec•org> wrote:
>>
>>
>> I asked it on one of the previous versions, but why do we need this limitation?
>> Update SA is actually add and delete, so if user wants to update
>> direction, it should be allowed.
>
> An SA can never change direction without dealing with updated SPIs. Logically,
> it makes no sense. Sure, if you treat SA’s as Linux lego bricks that can be
> turned into anything, then yeah why not. Why not turn the SA into block device
> or magic flute?
>
> If you keep to the RFC, an SA is uni directional. More things might apply too,
> eg the mode (transport vs tunnel) should not change, sequence numbers can only
> increase, etc.
I have to agree. When we add new direction specific attributes (e.g., iptfs send-rate, pkt-size, etc, for "out", reorder window size, drop-time for "in") changing direction would mean removing invalidating these attributes and possibly setting new different ones, deleting old send state adding new receive state, etc.. this doesn't feel like an SA update IMO, it feels like a new SA. I say we should apply KISS and just require a new SA for a different direction attribute.
Thanks,
Chris.
>
> Paul
next prev parent reply other threads:[~2024-04-11 17:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 9:40 [PATCH ipsec-next v10 1/3] xfrm: Add Direction to the SA in or out Antony Antony
2024-04-11 9:42 ` [PATCH ipsec-next v10 2/3] xfrm: Add dir validation to "out" data path lookup Antony Antony
2024-04-12 13:49 ` Nicolas Dichtel
2024-04-12 13:53 ` Nicolas Dichtel
2024-04-18 9:24 ` Simon Horman
2024-04-21 22:13 ` Antony Antony
2024-04-11 9:42 ` [PATCH ipsec-next v10 3/3] xfrm: Add dir validation to "in" " Antony Antony
2024-04-12 13:54 ` Nicolas Dichtel
2024-04-15 19:54 ` Antony Antony
2024-04-11 11:41 ` [PATCH ipsec-next v10 1/3] xfrm: Add Direction to the SA in or out Leon Romanovsky
2024-04-11 16:20 ` [devel-ipsec] " Paul Wouters
2024-04-11 16:40 ` Christian Hopps [this message]
2024-04-11 17:05 ` Leon Romanovsky
2024-04-15 12:21 ` Sabrina Dubroca
2024-04-16 7:10 ` [devel-ipsec] " Antony Antony
2024-04-16 8:36 ` Sabrina Dubroca
2024-04-21 22:04 ` Antony Antony
2024-04-22 9:16 ` Sabrina Dubroca
2024-04-22 9:54 ` Nicolas Dichtel
2024-04-23 12:42 ` Antony Antony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m24jc7lt50.fsf@chopps.org \
--to=chopps@chopps$(echo .)org \
--cc=antony.antony@secunet$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devel@linux-ipsec$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=eyal.birger@gmail$(echo .)com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicolas.dichtel@6wind$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=paul@nohats$(echo .)ca \
--cc=sd@queasysnail$(echo .)net \
--cc=steffen.klassert@secunet$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox