Subject: Re: [PATCH nf v1] netfilter: nfnetlink: Initialise extack before use in ACKs

From: Donald Hunter <[email-masked]>
Date: Fri, 09 Aug 2024 12:15:55 +0100

Simon Horman <[email-masked]> writes:

> On Tue, Aug 06, 2024 at 04:43:24PM +0100, Donald Hunter wrote:
>> Add missing extack initialisation when ACKing BATCH_BEGIN and BATCH_END.
>> 
>> Fixes: bf2ac490d28c ("netfilter: nfnetlink: Handle ACK flags for batch messages")
>> Signed-off-by: Donald Hunter <[email-masked]>
>
> Hi Donald,
>
> I see two other places that extack is used in nfnetlink_rcv_batch().
> Is it safe to leave them as-is?

There is a memset at the start of the main while loop that zeroes extack
for those two cases.