From: Christian Hopps <chopps@chopps•org>
To: Simon Horman <horms@kernel•org>
Cc: Christian Hopps <chopps@chopps•org>,
Steffen Klassert <steffen.klassert@secunet•com>,
netdev@vger•kernel.org, Christian Hopps <chopps@labn•net>,
devel@linux-ipsec•org
Subject: Re: [devel-ipsec] [PATCH ipsec-next v5 08/17] xfrm: iptfs: add new iptfs xfrm mode impl
Date: Wed, 17 Jul 2024 22:56:04 -0700 [thread overview]
Message-ID: <m28qxzdyzi.fsf@chopps.org> (raw)
In-Reply-To: <20240715123923.GB45692@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 3045 bytes --]
Simon Horman via Devel <devel@linux-ipsec•org> writes:
> On Sun, Jul 14, 2024 at 04:22:36PM -0400, Christian Hopps wrote:
>> From: Christian Hopps <chopps@labn•net>
>>
>> Add a new xfrm mode implementing AggFrag/IP-TFS from RFC9347.
>>
>> This utilizes the new xfrm_mode_cbs to implement demand-driven IP-TFS
>> functionality. This functionality can be used to increase bandwidth
>> utilization through small packet aggregation, as well as help solve PMTU
>> issues through it's efficient use of fragmentation.
>>
>> Link: https://www.rfc-editor.org/rfc/rfc9347.txt
>>
>> Multiple commits follow to build the functionality into xfrm_iptfs.c
>>
>> Signed-off-by: Christian Hopps <chopps@labn•net>
>> ---
>> net/xfrm/Makefile | 1 +
>> net/xfrm/xfrm_iptfs.c | 206 ++++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 207 insertions(+)
>> create mode 100644 net/xfrm/xfrm_iptfs.c
>>
>> diff --git a/net/xfrm/Makefile b/net/xfrm/Makefile
>> index 512e0b2f8514..5a1787587cb3 100644
>> --- a/net/xfrm/Makefile
>> +++ b/net/xfrm/Makefile
>> @@ -21,5 +21,6 @@ obj-$(CONFIG_XFRM_USER) += xfrm_user.o
>> obj-$(CONFIG_XFRM_USER_COMPAT) += xfrm_compat.o
>> obj-$(CONFIG_XFRM_IPCOMP) += xfrm_ipcomp.o
>> obj-$(CONFIG_XFRM_INTERFACE) += xfrm_interface.o
>> +obj-$(CONFIG_XFRM_IPTFS) += xfrm_iptfs.o
>> obj-$(CONFIG_XFRM_ESPINTCP) += espintcp.o
>> obj-$(CONFIG_DEBUG_INFO_BTF) += xfrm_state_bpf.o
>> diff --git a/net/xfrm/xfrm_iptfs.c b/net/xfrm/xfrm_iptfs.c
>> new file mode 100644
>> index 000000000000..414035a7a208
>> --- /dev/null
>> +++ b/net/xfrm/xfrm_iptfs.c
>> @@ -0,0 +1,206 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/* xfrm_iptfs: IPTFS encapsulation support
>> + *
>> + * April 21 2022, Christian Hopps <chopps@labn•net>
>> + *
>> + * Copyright (c) 2022, LabN Consulting, L.L.C.
>> + *
>> + */
>> +
>> +#include <linux/kernel.h>
>> +#include <linux/icmpv6.h>
>> +#include <net/gro.h>
>> +#include <net/icmp.h>
>> +#include <net/ip6_route.h>
>> +#include <net/inet_ecn.h>
>> +#include <net/xfrm.h>
>> +
>> +#include <crypto/aead.h>
>> +
>> +#include "xfrm_inout.h"
>> +
>> +struct xfrm_iptfs_config {
>> + u32 pkt_size; /* outer_packet_size or 0 */
>> +};
>> +
>> +struct xfrm_iptfs_data {
>> + struct xfrm_iptfs_config cfg;
>> +
>> + /* Ingress User Input */
>> + struct xfrm_state *x; /* owning state */
>> + u32 payload_mtu; /* max payload size */
>> +};
>> +
>> +/* ========================== */
>> +/* State Management Functions */
>> +/* ========================== */
>> +
>> +/**
>> + * iptfs_get_inner_mtu() - return inner MTU with no fragmentation.
>> + * @x: xfrm state.
>> + * @outer_mtu: the outer mtu
>> + */
>
> Hi Christian,
>
> Please consider including a "Return:" or "Returns:" section
> in the Kernel doc for functions that return values.
>
> Likewise elsewhere in this patchset.
>
> Flagged by: ./scripts/kernel-doc -none -Wall
>
>> +static u32 iptfs_get_inner_mtu(struct xfrm_state *x, int outer_mtu)
>
> ...
I've updated all the doc comments to include "Return:"s.
Thanks!
Chris.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
next prev parent reply other threads:[~2024-07-18 5:56 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-14 20:22 [PATCH ipsec-next v5 00/17] Add IP-TFS mode to xfrm Christian Hopps
2024-07-14 20:22 ` [PATCH ipsec-next v5 01/17] xfrm: config: add CONFIG_XFRM_IPTFS Christian Hopps
2024-07-14 20:22 ` [PATCH ipsec-next v5 02/17] include: uapi: add ip_tfs_*_hdr packet formats Christian Hopps
2024-07-14 20:22 ` [PATCH ipsec-next v5 03/17] include: uapi: add IPPROTO_AGGFRAG for AGGFRAG in ESP Christian Hopps
2024-07-14 20:22 ` [PATCH ipsec-next v5 04/17] xfrm: sysctl: allow configuration of global default values Christian Hopps
2024-07-18 13:13 ` Sabrina Dubroca
2024-07-18 13:15 ` Christian Hopps
2024-07-14 20:22 ` [PATCH ipsec-next v5 05/17] xfrm: netlink: add config (netlink) options Christian Hopps
2024-07-18 13:45 ` Sabrina Dubroca
2024-07-18 14:08 ` [devel-ipsec] " Christian Hopps
2024-07-14 20:22 ` [PATCH ipsec-next v5 06/17] xfrm: add mode_cbs module functionality Christian Hopps
2024-07-19 6:14 ` [devel-ipsec] " Florian Westphal
2024-07-20 0:06 ` Christian Hopps
2024-07-25 13:32 ` Sabrina Dubroca
2024-07-30 21:29 ` Christian Hopps
2024-07-31 17:10 ` Sabrina Dubroca
2024-07-31 18:32 ` Christian Hopps
2024-07-31 18:41 ` Christian Hopps
2024-07-14 20:22 ` [PATCH ipsec-next v5 07/17] xfrm: add generic iptfs defines and functionality Christian Hopps
2024-07-14 20:22 ` [PATCH ipsec-next v5 08/17] xfrm: iptfs: add new iptfs xfrm mode impl Christian Hopps
2024-07-15 12:39 ` Simon Horman
2024-07-18 5:56 ` Christian Hopps [this message]
2024-07-19 6:16 ` [devel-ipsec] " Florian Westphal
2024-07-20 0:30 ` Christian Hopps
2024-07-25 13:33 ` Sabrina Dubroca
2024-07-25 14:56 ` Christian Hopps
2024-07-31 16:29 ` Christian Hopps
2024-07-14 20:22 ` [PATCH ipsec-next v5 09/17] xfrm: iptfs: add user packet (tunnel ingress) handling Christian Hopps
2024-07-15 12:55 ` Simon Horman
2024-07-18 5:35 ` [devel-ipsec] " Christian Hopps
2024-07-18 6:32 ` Christian Hopps
2024-07-16 14:00 ` kernel test robot
2024-07-14 20:22 ` [PATCH ipsec-next v5 10/17] xfrm: iptfs: share page fragments of inner packets Christian Hopps
2024-07-14 20:22 ` [PATCH ipsec-next v5 11/17] xfrm: iptfs: add fragmenting of larger than MTU user packets Christian Hopps
2024-07-15 13:12 ` Simon Horman
2024-07-18 5:57 ` [devel-ipsec] " Christian Hopps
2024-07-18 6:56 ` Christian Hopps
2024-07-14 20:22 ` [PATCH ipsec-next v5 12/17] xfrm: iptfs: add basic receive packet (tunnel egress) handling Christian Hopps
2024-07-15 13:16 ` Simon Horman
2024-07-18 6:14 ` [devel-ipsec] " Christian Hopps
2024-07-14 20:22 ` [PATCH ipsec-next v5 13/17] xfrm: iptfs: handle received fragmented inner packets Christian Hopps
2024-07-14 20:22 ` [PATCH ipsec-next v5 14/17] xfrm: iptfs: add reusing received skb for the tunnel egress packet Christian Hopps
2024-07-14 20:22 ` [PATCH ipsec-next v5 15/17] xfrm: iptfs: add skb-fragment sharing code Christian Hopps
2024-07-14 20:22 ` [PATCH ipsec-next v5 16/17] xfrm: iptfs: handle reordering of received packets Christian Hopps
2024-07-14 20:22 ` [PATCH ipsec-next v5 17/17] xfrm: iptfs: add tracepoint functionality Christian Hopps
2024-07-15 11:53 ` kernel test robot
2024-07-17 5:21 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m28qxzdyzi.fsf@chopps.org \
--to=chopps@chopps$(echo .)org \
--cc=chopps@labn$(echo .)net \
--cc=devel@linux-ipsec$(echo .)org \
--cc=horms@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=steffen.klassert@secunet$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox