From: Andreas Schwab <schwab@linux-m68k•org>
To: David Miller <davem@davemloft•net>
Cc: eric.dumazet@gmail•com, netdev@vger•kernel.org
Subject: Re: [RFC] should we care of COMPAT mode in bridge ?
Date: Mon, 06 Jun 2011 22:31:55 +0200 [thread overview]
Message-ID: <m28vtevgzo.fsf@igel.home> (raw)
In-Reply-To: <20110606.130309.847468074358617705.davem@davemloft.net> (David Miller's message of "Mon, 06 Jun 2011 13:03:09 -0700 (PDT)")
David Miller <davem@davemloft•net> writes:
> From: Eric Dumazet <eric.dumazet@gmail•com>
> Date: Mon, 06 Jun 2011 21:45:40 +0200
>
>> While trying Alexander Holler patch, I found a 32bit brctl program was
>> not able to work on a 64bit kernel. So I had to switch to another
>> machine for my tests.
>>
>> brctl addbr mybridge
>> ->
>> socket(PF_FILE, SOCK_STREAM, 0) = 3
>> ioctl(3, SIOCSIFBR, 0xffd509c0) = -1 EINVAL (Invalid argument)
>>
>> Should we care or not ?
>
> I think we should make an effort to fix this.
OTOH, the SIOCSIFBR and SIOCGIFBR ioctls are obsoleted by the
SIOCBRADDBR, SIOCBRDELBR, SIOCBRADDIF, SIOCBRDELIF ioctls and bridge
sysfs files (which have no compat issues).
Andreas.
--
Andreas Schwab, schwab@linux-m68k•org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2011-06-06 20:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-06 19:45 [RFC] should we care of COMPAT mode in bridge ? Eric Dumazet
2011-06-06 20:03 ` David Miller
2011-06-06 20:23 ` Chris Friesen
2011-06-06 20:31 ` Arnd Bergmann
2011-06-06 20:31 ` Andreas Schwab [this message]
2011-06-06 20:34 ` Eric Dumazet
2011-06-07 23:51 ` Stephen Hemminger
2011-06-08 0:27 ` David Miller
2011-06-08 16:08 ` Stephen Hemminger
2011-06-06 20:06 ` Arnd Bergmann
2011-06-06 20:09 ` David Miller
2011-06-06 20:19 ` Arnd Bergmann
2011-06-06 20:23 ` David Miller
2011-06-07 23:54 ` Stephen Hemminger
2011-06-06 20:12 ` Eric Dumazet
2011-06-06 20:26 ` Arnd Bergmann
2011-06-06 20:32 ` Eric Dumazet
2011-06-06 20:33 ` Arnd Bergmann
2011-06-06 20:35 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m28vtevgzo.fsf@igel.home \
--to=schwab@linux-m68k$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox