Subject: Re: small RPS cache for fragments?

From: Andi Kleen <[email-masked]>
Date: Tue, 17 May 2011 14:44:42 -0700

Eric Dumazet <[email-masked]> writes:
>
> OK but do we have workloads actually needing this optimization at all ?

That's a good a question.
>
> (IP defrag hits a read_lock(&ip4_frags.lock)), so maybe steer all frags
> on a given cpu ?)

Couldn't the lock just be replaced with a hashed or bitmap lock or 
bit in low bits of pointer lock?

iirc it just protects the heads of the hash table.

They're not rwlocks, but especially if the locking was more finegrained
that's likely not needed anymore.

-Andi

-- 
[email-masked] -- Speaking for myself only