Subject: Re: [PATCH net-next v2 3/8] netlink: specs: Expand the PSE netlink command with C33 new features

From: Donald Hunter <[email-masked]>
Date: Fri, 07 Jun 2024 11:09:38 +0100

Kory Maincent <[email-masked]> writes:

> From: "Kory Maincent (Dent Project)" <[email-masked]>
>
> Expand the c33 PSE attributes with PSE class, extended state information
> and power consumption.
>
> ./ynl/cli.py --spec netlink/specs/ethtool.yaml --no-schema --do pse-get
> 	     --json '{"header":{"dev-name":"eth0"}}'
> {'c33-pse-actual-pw': 1700,
>  'c33-pse-admin-state': 3,
>  'c33-pse-pw-class': 4,
>  'c33-pse-pw-d-status': 4,
>  'header': {'dev-index': 4, 'dev-name': 'eth0'}}
>
> ./ynl/cli.py --spec netlink/specs/ethtool.yaml --no-schema --do pse-get
> 	     --json '{"header":{"dev-name":"eth0"}}'
> {'c33-pse-admin-state': 3,
>  'c33-pse-ext-state': 5,
>  'c33-pse-ext-substate': 5,
>  'c33-pse-pw-d-status': 2,
>  'header': {'dev-index': 4, 'dev-name': 'eth0'}}
>
> Signed-off-by: Kory Maincent <[email-masked]>
> ---
>  Documentation/netlink/specs/ethtool.yaml | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/Documentation/netlink/specs/ethtool.yaml b/Documentation/netlink/specs/ethtool.yaml
> index 00dc61358be8..8aa064f2f466 100644
> --- a/Documentation/netlink/specs/ethtool.yaml
> +++ b/Documentation/netlink/specs/ethtool.yaml
> @@ -922,6 +922,22 @@ attribute-sets:
>          name: c33-pse-pw-d-status
>          type: u32
>          name-prefix: ethtool-a-
> +      -
> +        name: c33-pse-pw-class
> +        type: u32
> +        name-prefix: ethtool-a-
> +      -
> +        name: c33-pse-actual-pw
> +        type: u32
> +        name-prefix: ethtool-a-
> +      -
> +        name: c33-pse-ext-state
> +        type: u8
> +        name-prefix: ethtool-a-
> +      -
> +        name: c33-pse-ext-substate
> +        type: u8
> +        name-prefix: ethtool-a-

I see this is consistent with existing pse attributes in the spec, but
are there enumerations for the state and status attributes that could be
added to the spec?

>    -
>      name: rss
>      attributes:
> @@ -1611,6 +1627,10 @@ operations:
>              - c33-pse-admin-state
>              - c33-pse-admin-control
>              - c33-pse-pw-d-status
> +            - c33-pse-pw-class
> +            - c33-pse-actual-pw
> +            - c33-pse-ext-state
> +            - c33-pse-ext-substate
>        dump: *pse-get-op
>      -
>        name: pse-set