Subject: Re: [RFC 3/9] snet: introduce security/snet, Makefile and Kconfig changes

From: Samir Bellabes <[email-masked]>
Date: Wed, 06 Jan 2010 07:04:07 +0100

"Serge E. Hallyn" <[email-masked]> writes:

>> diff --git a/security/snet/Kconfig b/security/snet/Kconfig
>> new file mode 100644
>> index 0000000..e1516a1
>> --- /dev/null
>> +++ b/security/snet/Kconfig
>> @@ -0,0 +1,22 @@
>> +#
>> +# snet
>> +#
>> +
>> +config SECURITY_SNET
>> +	bool "snet - Security for NETwork syscalls"
>> +	depends on SECURITY_NETWORK && IPV6
>
> Why depend on IPV6?

right, no need.

>
>> +	default n
>> +	---help---
>> +	Provide a generic netlink that reports networking's syscalls
>> +	to userspace
>
> And also wait for userspace to decide whether to authorize the
> syscall, right?  'report on' is very different.

I'm proposing this patch, which applies on top of previous

diff --git a/security/snet/Kconfig b/security/snet/Kconfig
index e1516a1..8ac7778 100644
--- a/security/snet/Kconfig
+++ b/security/snet/Kconfig
@@ -4,11 +4,11 @@
 
 config SECURITY_SNET
 	bool "snet - Security for NETwork syscalls"
-	depends on SECURITY_NETWORK && IPV6
+	depends on SECURITY_NETWORK
 	default n
 	---help---
-	Provide a generic netlink that reports networking's syscalls
-	to userspace
+	If this option is enabled, the kernel will include support for reporting
+	networking's syscalls to userspace and wait for a verdict
 
 config SECURITY_SNET_DEBUG
        bool "snet debug messages"