Subject: Re: [RFC 6/9] snet: introduce snet_hooks.c and snet_hook.h

From: Samir Bellabes <[email-masked]>
Date: Sun, 03 Jan 2010 23:26:48 +0100

Stephen Hemminger <[email-masked]> writes:

> On Sun, 03 Jan 2010 12:10:53 +0100
> Samir Bellabes <[email-masked]> wrote:
>
>> I know it's ugly, but code in security hooks are duplicated.
>> functions (inline or not), which replace this macros, will resulte of
>> having lots of parameters. macros with external object seems to be the
>> most simple at this point.
>
> Macro's with references to thing outside of the argument are just
> plain wrong. They introduce bugs that humans don't see.

right.
I will move this macros to inline functions.

thanks,
sam