Subject: Re: [PATCH net-next v2 2/2] netlink: specs: Add a spec for FIB rule management

From: Donald Hunter <[email-masked]>
Date: Tue, 05 Nov 2024 15:28:29 +0000

Ido Schimmel <[email-masked]> writes:

> On Tue, Nov 05, 2024 at 12:28:31PM +0000, Donald Hunter wrote:
>
> Reviewed-by: Ido Schimmel <[email-masked]>
>
> One question below (didn't notice it before)
>
> [...]
>
>> +    -
>> +      name: getrule
>> +      doc: Dump all FIB rules
>> +      attribute-set: fib-rule-attrs
>> +      dump:
>> +        request:
>> +          value: 34
>> +          attributes:
>> +            - nsid
>
> What is the significance of 'nsid' here?

Hmm, looks like a couple of lines I need to remove.

Thanks for catching this!