Subject: Re: [PATCH v3] ipv6: Fix protocol resubmission

From: Hajime Tazaki <[email-masked]>
Date: Wed, 10 Jun 2015 13:24:08 +0900

Hello Josh, Dave,

my mobile ipv6 test on libos failed with this commit.

This commit makes a destination option header handling (i.e.,
ipprot->handler == ipv6_destopt_rcv) failed since
ipv6_destopt_rcv() seems to return a positive value to
indicate to goto resubmission label.

I will look for more detail.

-- Hajime

At Mon, 08 Jun 2015 12:16:01 -0700 (PDT),
David Miller wrote:
> 
> From: Josh Hunt <[email-masked]>
> Date: Mon,  8 Jun 2015 12:00:59 -0400
> 
> > UDP encapsulation is broken on IPv6. This is because the logic to resubmit
> > the nexthdr is inverted, checking for a ret value > 0 instead of < 0. Also,
> > the resubmit label is in the wrong position since we already get the
> > nexthdr value when performing decapsulation. In addition the skb pull is no
> > longer necessary either.
> > 
> > This changes the return value check to look for < 0, using it for the
> > nexthdr on the next iteration, and moves the resubmit label to the proper
> > location.
> > 
> > With these changes the v6 code now matches what we do in the v4 ip input
> > code wrt resubmitting when decapsulating.
> > 
> > Signed-off-by: Josh Hunt <[email-masked]>
> 
> Applied.