Subject: Re: [PATCH net-next v2 3/3] tools/net/ynl: Add multi message support to ynl

From: Donald Hunter <[email-masked]>
Date: Fri, 12 Apr 2024 10:53:43 +0100

Jakub Kicinski <[email-masked]> writes:

> On Wed, 10 Apr 2024 23:11:08 +0100 Donald Hunter wrote:
>> -    def do(self, method, vals, flags=None):
>> +    def _op(self, method, vals, flags):
>> +        ops = [(method, vals, flags)]
>> +        return self._ops(ops)[0]
>> +
>> +    def do(self, method, vals, flags=[]):
>>          return self._op(method, vals, flags)
>
> Commenting here instead of on my own series but there are already tests
> using dump=True in net-next:
>
> tools/testing/selftests/drivers/net/stats.py:    stats = netfam.qstats_get({}, dump=True)
> tools/testing/selftests/net/nl_netdev.py:        devs = nf.dev_get({}, dump=True)
>
> "flags=[Netlink.NLM_F_DUMP]" is going to be a lot less convenient 
> to write :( Maybe we can keep support for both?

Good catch, I overlooked the generated methods. I'll make sure to add it
back in.