From: Christian Hopps <chopps@chopps•org>
To: Herbert Xu <herbert@gondor•apana.org.au>
Cc: Christian Hopps <chopps@chopps•org>,
Steffen Klassert <steffen.klassert@secunet•com>,
"David S. Miller" <davem@davemloft•net>,
devel@linux-ipsec•org, Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
netdev@vger•kernel.org, chopps@labn•net
Subject: Re: [PATCH ipsec-next v2] xfrm: fix bug with DSCP copy to v6 from v4 tunnel
Date: Fri, 27 Jan 2023 07:22:40 -0500 [thread overview]
Message-ID: <m2sffw17ti.fsf@ja.int.chopps.org> (raw)
In-Reply-To: <Y9OpfMipCnPafoPL@gondor.apana.org.au>
Herbert Xu <herbert@gondor•apana.org.au> writes:
> On Thu, Jan 26, 2023 at 11:33:50AM -0500, Christian Hopps wrote:
>> When copying the DSCP bits for decap-dscp into IPv6 don't assume the
>> outer encap is always IPv6. Instead, as with the inner IPv4 case, copy
>> the DSCP bits from the correctly saved "tos" value in the control block.
>>
>> Fixes: 227620e29509 ("[IPSEC]: Separate inner/outer mode processing on input")
>
> Please fix this Fixes header as that commit did not introduce
> this bug.
This was a suggested add from Eyal that I was initially hesitant to add. He justified it b/c this commit purported to add support for mixed versions and this is a bug in that new functionality. It is useful to have that tracked which is why I added it. Is there a better way to track that?
Thanks,
Chris.
next prev parent reply other threads:[~2023-01-27 12:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 10:29 [PATCH] xfrm: fix bug with DSCP copy to v6 from v4 tunnel Christian Hopps
2023-01-26 16:33 ` [PATCH ipsec-next v2] " Christian Hopps
2023-01-27 10:37 ` Herbert Xu
2023-01-27 12:22 ` Christian Hopps [this message]
2023-01-28 1:42 ` Herbert Xu
2023-02-01 8:21 ` Steffen Klassert
2023-01-27 10:10 ` [PATCH] " Herbert Xu
2023-01-27 12:31 ` Christian Hopps
2023-01-28 1:41 ` Herbert Xu
2023-01-27 22:58 ` [PATCH ipsec-next v3] " Christian Hopps
2023-01-28 1:38 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2sffw17ti.fsf@ja.int.chopps.org \
--to=chopps@chopps$(echo .)org \
--cc=chopps@labn$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=devel@linux-ipsec$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=steffen.klassert@secunet$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox