From: Christian Hopps <chopps@labn•net>
To: Antony Antony <antony@phenome•org>
Cc: Christian Hopps <chopps@labn•net>,
Andrew Cagney <andrew.cagney@gmail•com>,
devel@linux-ipsec•org, netdev@vger•kernel.org,
Steffen Klassert <steffen.klassert@secunet•com>
Subject: Re: [DKIM] Re: [devel-ipsec] [RFC ipsec-next v2 0/8] Add IP-TFS mode to xfrm
Date: Mon, 20 Nov 2023 15:14:15 -0500 [thread overview]
Message-ID: <m2wmucyyap.fsf@ja.int.chopps.org> (raw)
In-Reply-To: <ZVu668MJ2iEr4fRG@Antony2201.local>
[-- Attachment #1: Type: text/plain, Size: 1526 bytes --]
Antony Antony <antony@phenome•org> writes:
> On Mon, Nov 20, 2023 at 01:39:50PM -0500, Christian Hopps via Devel wrote:
>>
>> Andrew Cagney <andrew.cagney@gmail•com> writes:
>>
>> > > I did a multiple days peer review with Chris on this pachset. So my
>> > > concerns are already addressed.
>> > >
>> > > Further reviews are welcome! This is a bigger change and it would
>> > > be nice if more people could look at it.
>> >
>> > I have a usability question. What name should appear when a user
>> > interacts with and sees log messages from this feature?
>> > ip-tfs, IP-TFS, IP_TFS
>> > or:
>> > iptfs, IPTFS, ...
>>
>> I think no `-` or `_` in the code/api. For documentation it is probably better to hew closer to the RFC and use `IP-TFS`.
>
> That sounds good. However,
> iproute2 output, ip xfrm state, or "ip xfrm policy" is that documentation or code?
>
> current unsubmitted patch shows: "iptfs"
That's code/api. I was thinking ui/api when I said api.
Documentation would be something ending in a .rst or within a comment as that might be referring to the RFC too.
I will go through and make sure things are consistent in the next version.
Thanks,
Chris.
>
> src 192.1.2.23 dst 192.1.2.45
> proto esp spi 0x76ee6b87(1995336583) reqid 16389(0x00004005) mode iptfs
>
> root@west:/testing/pluto/ikev2-74-iptfs-01 (iptfs-aa-20231120)# ip x p
> src 192.0.1.0/24 dst 192.0.2.0/24
> dir out priority 1757393 ptype main
> tmpl src 192.1.2.45 dst 192.1.2.23
> proto esp reqid 16389 mode iptfs
>
> -antony
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 858 bytes --]
next prev parent reply other threads:[~2023-11-20 20:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 3:52 [RFC ipsec-next v2 0/8] Add IP-TFS mode to xfrm Christian Hopps
2023-11-13 3:52 ` [RFC ipsec-next v2 1/8] iptfs: config: add CONFIG_XFRM_IPTFS Christian Hopps
2023-11-13 3:52 ` [RFC ipsec-next v2 2/8] iptfs: uapi: ip: add ip_tfs_*_hdr packet formats Christian Hopps
2023-11-20 15:28 ` Sabrina Dubroca
2023-11-20 20:18 ` Christian Hopps
2023-11-20 22:38 ` Sabrina Dubroca
2024-02-01 14:15 ` Christian Hopps
2023-11-13 3:52 ` [RFC ipsec-next v2 3/8] iptfs: uapi: IPPROTO_AGGFRAG AGGFRAG in ESP Christian Hopps
2023-11-13 3:52 ` [RFC ipsec-next v2 4/8] iptfs: sysctl: allow configuration of global default values Christian Hopps
2023-11-20 23:05 ` Sabrina Dubroca
2024-02-01 13:57 ` Christian Hopps
2023-11-13 3:52 ` [RFC ipsec-next v2 5/8] iptfs: netlink: add config (netlink) options Christian Hopps
2023-11-30 15:36 ` Sabrina Dubroca
2023-11-13 3:52 ` [RFC ipsec-next v2 6/8] iptfs: xfrm: Add mode_cbs module functionality Christian Hopps
2023-11-13 14:07 ` [devel-ipsec] " Antony Antony
2023-11-15 19:04 ` Antony Antony
2023-11-30 15:35 ` Sabrina Dubroca
2024-02-01 15:34 ` Christian Hopps
2023-11-13 3:52 ` [RFC ipsec-next v2 7/8] iptfs: xfrm: add generic iptfs defines and functionality Christian Hopps
2023-11-13 3:52 ` [RFC ipsec-next v2 8/8] iptfs: impl: add new iptfs xfrm mode impl Christian Hopps
2023-11-30 15:33 ` Sabrina Dubroca
2024-02-02 9:44 ` Christian Hopps
2023-11-13 7:15 ` [RFC ipsec-next v2 0/8] Add IP-TFS mode to xfrm Steffen Klassert
2023-11-16 15:14 ` [devel-ipsec] " Andrew Cagney
2023-11-20 18:39 ` Christian Hopps
2023-11-20 20:00 ` [DKIM] " Antony Antony
2023-11-20 20:02 ` Antony Antony
2023-11-20 20:14 ` Christian Hopps [this message]
2023-11-21 19:13 ` Antony Antony
2023-11-16 16:02 ` Antony Antony
2024-03-07 11:05 ` Christian Hopps
2024-03-10 20:34 ` Antony Antony
2023-11-28 22:12 ` Antony Antony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2wmucyyap.fsf@ja.int.chopps.org \
--to=chopps@labn$(echo .)net \
--cc=andrew.cagney@gmail$(echo .)com \
--cc=antony@phenome$(echo .)org \
--cc=devel@linux-ipsec$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=steffen.klassert@secunet$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox