From: Donald Hunter <donald.hunter@gmail•com>
To: Jakub Kicinski <kuba@kernel•org>
Cc: davem@davemloft•net, netdev@vger•kernel.org,
edumazet@google•com, pabeni@redhat•com
Subject: Re: [PATCH net-next 3/5] tools: ynl-gen: fix collecting global policy attrs
Date: Thu, 24 Aug 2023 14:11:17 +0100 [thread overview]
Message-ID: <m2wmxkfuve.fsf@gmail.com> (raw)
In-Reply-To: <20230824003056.1436637-4-kuba@kernel.org> (Jakub Kicinski's message of "Wed, 23 Aug 2023 17:30:54 -0700")
Jakub Kicinski <kuba@kernel•org> writes:
> We look for attributes inside do.request, but there's another
> layer of nesting in the spec, look inside do.request.attributes.
>
> This bug had no effect as all global policies we generate (fou)
> seem to be full, anyway, and we treat full and empty the same.
>
> Next patch will change the treatment of empty policies.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel•org>
> ---
> tools/net/ynl/ynl-gen-c.py | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tools/net/ynl/ynl-gen-c.py b/tools/net/ynl/ynl-gen-c.py
> index e27deb199a70..13d06931c045 100755
> --- a/tools/net/ynl/ynl-gen-c.py
> +++ b/tools/net/ynl/ynl-gen-c.py
> @@ -978,7 +978,9 @@ from lib import SpecFamily, SpecAttrSet, SpecAttr, SpecOperation, SpecEnumSet, S
>
> for op_mode in ['do', 'dump']:
> if op_mode in op:
> - global_set.update(op[op_mode].get('request', []))
> + req = op[op_mode].get('request')
> + if req:
> + global_set.update(req.get('attributes', []))
>
> self.global_policy = []
> self.global_policy_set = attr_set_name
Reviewed-by: Donald Hunter <donald.hunter@gmail•com>
next prev parent reply other threads:[~2023-08-24 13:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 0:30 [PATCH net-next 0/5] tools: ynl: handful of forward looking updates Jakub Kicinski
2023-08-24 0:30 ` [PATCH net-next 1/5] tools: ynl: allow passing binary data Jakub Kicinski
2023-08-24 13:09 ` Donald Hunter
2023-08-24 0:30 ` [PATCH net-next 2/5] tools: ynl-gen: set length of binary fields Jakub Kicinski
2023-08-24 13:16 ` Donald Hunter
2023-08-24 0:30 ` [PATCH net-next 3/5] tools: ynl-gen: fix collecting global policy attrs Jakub Kicinski
2023-08-24 13:11 ` Donald Hunter [this message]
2023-08-24 0:30 ` [PATCH net-next 4/5] tools: ynl-gen: support empty attribute lists Jakub Kicinski
2023-08-24 13:10 ` Donald Hunter
2023-08-24 0:30 ` [PATCH net-next 5/5] netlink: specs: fix indent in fou Jakub Kicinski
2023-08-24 13:17 ` Donald Hunter
2023-08-25 2:10 ` [PATCH net-next 0/5] tools: ynl: handful of forward looking updates patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2wmxkfuve.fsf@gmail.com \
--to=donald.hunter@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox