Subject: Re: [PATCH net-next v5 11/12] doc/netlink: Add spec for rt link messages

From: Donald Hunter <[email-masked]>
Date: Fri, 25 Aug 2023 10:04:20 +0100

Jiri Pirko <[email-masked]> writes:

> Thu, Aug 24, 2023 at 01:20:02PM CEST, [email-masked] wrote:
>
> [...]
>
>>+attribute-sets:
>>+  -
>>+    name: link-attrs
>>+    name-prefix: ifla-
>>+    attributes:
>>+      -
>>+        name: address
>>+        type: binary
>>+        display-hint: mac
>>+        value: 1
>>+      -
>>+        name: broadcast
>>+        type: binary
>>+        display-hint: mac
>>+        value: 2
>
> Why do you specify value here? In general, it is not needed if it
> is the prev+1.

I added the values when I generated some of the spec contents from
btftool output and they were helpful for visual lookup when I was
working on the spec.

I can remove them.

>>+      -
>>+        name: ifname
>>+        type: string
>>+        value: 3
> [...]