Subject: Re: [PATCH net-next v2 08/11] tools/net/ynl: Add binary and pad support to structs for tc

From: Donald Hunter <[email-masked]>
Date: Tue, 12 Dec 2023 11:36:03 +0000

Jakub Kicinski <[email-masked]> writes:

> On Mon, 11 Dec 2023 16:40:36 +0000 Donald Hunter wrote:
>>                  description: The netlink attribute type
>
> We should perhaps "touch up" this doc, and add that for the use of pad
> within structs len is required. Would be even better if you could
> convince json schema to validate that. The example that starts with 
> a comment:
>
>   # type property is only required if not in subset definition
>
> should be pretty close to what we need here?

Yep, I'll update the description and see if I can get the schema
validation to play nice.

>
>> -                enum: [ u8, u16, u32, u64, s8, s16, s32, s64, string, binary ]
>> +                enum: [ u8, u16, u32, u64, s8, s16, s32, s64, string, binary, pad ]