From: Vincent Bernat <vincent@bernat•ch>
To: Jiri Pirko <jiri@resnulli•us>
Cc: Jay Vosburgh <j.vosburgh@gmail•com>,
Veaceslav Falico <vfalico@gmail•com>,
Andy Gospodarek <andy@greyhouse•net>,
"David S. Miller" <davem@davemloft•net>,
netdev@vger•kernel.org
Subject: Re: [PATCH net-next v1] bonding: add an option to specify a delay between peer notifications
Date: Mon, 01 Jul 2019 11:32:12 +0200 [thread overview]
Message-ID: <m3h886f6cj.fsf@bernat.ch> (raw)
In-Reply-To: <20190701092758.GA2250@nanopsycho> (Jiri Pirko's message of "Mon, 1 Jul 2019 11:27:58 +0200")
❦ 1 juillet 2019 11:27 +02, Jiri Pirko <jiri@resnulli•us>:
>>+module_param(peer_notif_delay, int, 0);
>>+MODULE_PARM_DESC(peer_notif_delay, "Delay between each peer notification on "
>>+ "failover event, in milliseconds");
>
> No module options please. Use netlink. See bond_changelink() function.
It's also present in the patch. I'll do a v2 removing the ability to set
the default value through a module parameter.
--
Don't patch bad code - rewrite it.
- The Elements of Programming Style (Kernighan & Plauger)
next prev parent reply other threads:[~2019-07-01 9:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-30 18:59 [PATCH net-next v1] bonding: add an option to specify a delay between peer notifications Vincent Bernat
2019-07-01 9:27 ` Jiri Pirko
2019-07-01 9:32 ` Vincent Bernat [this message]
2019-07-02 17:43 ` [PATCH net-next v2] " Vincent Bernat
2019-07-04 19:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3h886f6cj.fsf@bernat.ch \
--to=vincent@bernat$(echo .)ch \
--cc=andy@greyhouse$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=j.vosburgh@gmail$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=vfalico@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox