public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed

From: Andi Kleen <ak@muc•de>
To: davem@redhat•com
Cc: netdev@oss•sgi.com, arjanv@redhat•com
Subject: [PATCH] Fix locking bug in lltx path
Date: Mon, 13 Sep 2004 20:11:00 +0200	[thread overview]
Message-ID: <m3vfei9gzv.fsf@averell.firstfloor.org> (raw)


Thanks to Arjan's spinlock debug kernel for finding it.

This fixes a silly missing spin lock in the relock path. For some 
reason it seems to still work when you don't have spinlock debugging
enabled.

Please apply.

-Andi

--------------------------------------------------------------------

Fix missing spin lock in lltx path.

Thanks to Arjan's spinlock debug kernel for finding it.

Signed-off-by: Andi Kleen <ak@muc•de>

diff -u linux-2.6.9rc1-bk19/net/sched/sch_generic.c-X linux-2.6.9rc1-bk19/net/sched/sch_generic.c
--- linux-2.6.9rc1-bk19/net/sched/sch_generic.c-X	2004-09-13 08:51:46.000000000 +0200
+++ linux-2.6.9rc1-bk19/net/sched/sch_generic.c	2004-09-13 19:22:50.000000000 +0200
@@ -153,8 +153,10 @@
 					spin_lock(&dev->queue_lock);
 					return -1;
 				}
-				if (ret == -1 && nolock)
+				if (ret == -1 && nolock) {
+					spin_lock(&dev->queue_lock);
 					goto collision; 
+				}
 			}
 
 			/* Release the driver */

next             reply	other threads:[~2004-09-13 18:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-13 18:11 Andi Kleen [this message]
2004-09-13 19:18 ` [PATCH] Fix locking bug in lltx path David S. Miller
2004-09-13 19:26   ` Andi Kleen
2004-09-13 20:02     ` David S. Miller
2004-09-13 19:39 ` Jeff Garzik
2004-09-14  1:43 ` jamal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3vfei9gzv.fsf@averell.firstfloor.org \
    --to=ak@muc$(echo .)de \
    --cc=arjanv@redhat$(echo .)com \
    --cc=davem@redhat$(echo .)com \
    --cc=netdev@oss$(echo .)sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox