From: Damian Lukowski <damian@tvk•rwth-aachen.de>
To: Denys Fedoryshchenko <denys@visp•net.lb>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@helsinki•fi>,
Netdev <netdev@vger•kernel.org>,
"David Miller" <davem@davemloft•net>
Subject: Re: [PATCH] tcp: fix ICMP-RTO war
Date: Sat, 30 Jan 2010 14:56:37 +0100 [thread overview]
Message-ID: <op.u7cmcnxvp498uc@nexus> (raw)
In-Reply-To: <201001301535.43469.denys@visp.net.lb>
> On Friday 29 January 2010 23:45:35 Damian Lukowski wrote:
>> Denys Fedoryshchenko schrieb:
>> > On Friday 29 January 2010 14:13:18 Damian Lukowski wrote:
>> >> Denys Fedoryshchenko schrieb:
>> >>> On Wednesday 27 January 2010 14:36:18 you wrote:
>> >>>> Unless they are for a different connection? We might have to print
>> sk
>> >>>> (%p) in all those printouts to be sure which maps to which. If a
>> peer
>> >>>> becomes unreachable, it may well have multiple connections open
>> (this
>> >>>> was a proxy, iirc?).
>> >>>
>> >>> Ok i will try to do that today.
>> >>>
>> >>> Most probably different connections, on this proxy i have 10-15k
>> >>> established connections at peak time.
>> >
>> > http://www.nuclearcat.com/files/report1.txt
>> > http://www.nuclearcat.com/files/report2.txt
>> >
>> > Here with %p and sk.
>>
>> Ok, thanks for testing.
>> So it is ec0f3440 causing the trouble. Are there still objections
>> on the lower bound check in __tcp_set_rto()? Well, I will submit
>> an updated patch and you can make comments there.
> There is another sk also. I can catch for more time - there is many
> different
> pointers to sk appearing (but not in same time, it is rare case even
> with my thousands of connections).
Hmm, I shouldn't have posted so late yesterday, as I forgot to CC
you and the others when submitting the patch, amongst the grammar error. :/
Can you test the patch in
http://marc.info/?l=linux-netdev&m=126480336216898
please?
Damian
next prev parent reply other threads:[~2010-01-30 13:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 13:56 [PATCH] tcp: fix ICMP-RTO war Denys Fedoryshchenko
2010-01-29 12:13 ` Damian Lukowski
2010-01-29 15:15 ` Denys Fedoryshchenko
2010-01-29 21:45 ` Damian Lukowski
2010-01-30 13:35 ` Denys Fedoryshchenko
2010-01-30 13:56 ` Damian Lukowski [this message]
2010-02-07 10:28 ` Denys Fedoryshchenko
-- strict thread matches above, loose matches on Subject: below --
2009-12-26 15:03 Crazy TCP bug (keepalive flood?) in 2.6.32? Denys Fedoryshchenko
2010-01-19 11:09 ` Denys Fedoryshchenko
2010-01-19 11:17 ` Ilpo Järvinen
2010-01-23 21:37 ` Denys Fedoryshchenko
2010-01-23 22:34 ` [PATCH] tcp: fix ICMP-RTO war Ilpo Järvinen
2010-01-23 22:45 ` Denys Fedoryshchenko
2010-01-25 15:07 ` Damian Lukowski
2010-01-26 7:45 ` David Miller
2010-01-27 12:41 ` Ilpo Järvinen
2010-01-27 14:14 ` Alexey Kuznetsov
2010-01-23 23:28 ` Denys Fedoryshchenko
2010-01-25 12:12 ` Damian Lukowski
2010-01-27 12:36 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=op.u7cmcnxvp498uc@nexus \
--to=damian@tvk$(echo .)rwth-aachen.de \
--cc=davem@davemloft$(echo .)net \
--cc=denys@visp$(echo .)net.lb \
--cc=ilpo.jarvinen@helsinki$(echo .)fi \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox