public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor•org>
To: Eric Dumazet <dada1@cosmosbay•com>
Cc: "Herbert Xu" <herbert@gondor•apana.org.au>,
	"YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6•org>,
	davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: UDP-Lite and /proc/net/snmp
Date: Sat, 10 Nov 2007 21:48:41 +0100	[thread overview]
Message-ID: <p733avd25ee.fsf@bingen.suse.de> (raw)
In-Reply-To: <4735CB59.2050708@cosmosbay.com> (Eric Dumazet's message of "Sat\, 10 Nov 2007 16\:16\:41 +0100")

Eric Dumazet <dada1@cosmosbay•com> writes:
>
> I meant a netstat bug of course, sorry :(
>
> It fails to parse /proc/net/netstat , because TcpExt line is bigger
> than 1024 chars.

guilty -- i wrote that code a long time ago.

>
> To correct it, we might enlarge buf1[] and buf2[] from 1024 to 2048 in
> statistics.c, process_fd() function.

Or just split TcpExt: into multiple lines, e.g. with a TcpExt2: 
No reason to have it all on a single line anyways.
I think that would be the better fix.

-Andi

      parent reply	other threads:[~2007-11-10 20:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-10 13:14 UDP-Lite and /proc/net/snmp Herbert Xu
2007-11-10 13:32 ` YOSHIFUJI Hideaki / 吉藤英明
2007-11-10 13:55   ` Eric Dumazet
2007-11-10 14:33   ` Herbert Xu
2007-11-10 14:48     ` YOSHIFUJI Hideaki / 吉藤英明
2007-11-10 14:55       ` Herbert Xu
2007-11-10 15:06         ` Eric Dumazet
2007-11-10 15:16           ` Eric Dumazet
2007-11-10 15:43             ` Herbert Xu
2007-11-10 20:48             ` Andi Kleen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p733avd25ee.fsf@bingen.suse.de \
    --to=andi@firstfloor$(echo .)org \
    --cc=dada1@cosmosbay$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=herbert@gondor$(echo .)apana.org.au \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=yoshfuji@linux-ipv6$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox