Subject: Re: [PATCH 2/14] nes: device structures and defines

From: Andi Kleen <[email-masked]>
Date: 08 Aug 2007 14:38:10 +0200

Jeff Garzik <[email-masked]> writes:
> > +			val, reg_index, addr, addr+4); */
> > +	writel(cpu_to_le32(reg_index), addr);
> > +	writel(cpu_to_le32(val),(u8 *)addr + 4);
> 
> wrong -- endian conversion macros not needed with writel()

Are you sure? I don't think that's true. e.g. powerpc writel 
doesn't convert endian

-Andi