Subject: Re: [PATCH 2.6.25 1/1]S2io: Multiqueue network device support implementation

From: Andi Kleen <[email-masked]>
Date: 23 Jan 2008 11:58:14 +0100

Sreenivasa Honnur <[email-masked]> writes:

> Multiqueue netwrok device support implementation.
> - Added a loadable parameter "multiq" to enable/disable multiqueue support,
>   by default it is disabled.
> - skb->queue_mapping is not used for queue/fifo selection. FIFO iselection is
>   based on IP-TOS value, 0x0-0xF TOS values are mapped to 8 FIFOs.

Standard way to use that would be using skb->priority

But I'm surprised you bother with TOS for multi queues at all. TOS
isn't a too important mechanism.

I would have thought the primary use case would be per CPU TX completion
interrupts. With that the queue should be selected based on
the the current CPU.

-Andi