Subject: Re: [PATCH] [2/2] Remove some unnecessary gotos in established_get_first()

From: Andi Kleen <[email-masked]>
Date: Wed, 30 Jan 2008 09:27:41 +0100

Oliver Neukum <[email-masked]> writes:

> Am Mittwoch, 30. Januar 2008 09:01:10 schrieb Andi Kleen:
>> 
>> gcc does not generate different code for return foo vs bar = foo; goto x;
>> x: return bar; So convert it all to direct returns for better readability.
>
> Now suppose somebody needs to change locking. He'll have to convert
> it back. 

Please take a look at the overall /proc/net/tcp logic. Any locking 
change will be a major change to the code flow of the whole family
of funtions.

-Andi