From: "Wentao Guan" <guanwentao@uniontech•com>
To: "Russell King (Oracle)" <linux@armlinux•org.uk>,
王昱力 <wangyuli@uniontech•com>
Cc: andrew <andrew@lunn•ch>, hkallweit1 <hkallweit1@gmail•com>,
davem <davem@davemloft•net>, edumazet <edumazet@google•com>,
kuba <kuba@kernel•org>, pabeni <pabeni@redhat•com>,
netdev <netdev@vger•kernel.org>,
linux-kernel <linux-kernel@vger•kernel.org>,
占俊 <zhanjun@uniontech•com>, "f.fainelli" <f.fainelli@gmail•com>,
"sebastian.hesselbarth" <sebastian.hesselbarth@gmail•com>,
mugunthanvnm <mugunthanvnm@ti•com>,
geert+renesas <geert+renesas@glider•be>
Subject: Re: [PATCH] net: phy: fix may not suspend when phy has WoL
Date: Mon, 11 Nov 2024 18:59:29 +0800 [thread overview]
Message-ID: <tencent_4B3AACEA45FBC48A019C11B2@qq.com> (raw)
In-Reply-To: <ZzHW4wOAH769WSJ0@shell.armlinux.org.uk>
Well question, but I do not know any knowledge about phydrv->suspend may or not return EBUSY?
Around the WoL state handling is becoming complex for checking the same logic in phy_suspend
and mdio_bus_phy_may_suspend.
I still do not know why that we need to use -EBUSY in 11 years ago
commit("481b5d9" net: phy: provide phy_resume/phy_suspend helpers)
If it is not need, maybe a simple solution is change EBUSY to 0 and add a warning print?
And discussing the patch, it is same as commit 4f534b7f0 in v6.12-rc1, and it context should before
"if (!drv || !phydrv->suspend)" check[It goes wrong when I moving the patch from our dist branch to upstream branch]
, so I send a NAK for the patch.
BRs
Wentao Guan
prev parent reply other threads:[~2024-11-11 10:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 8:06 [PATCH] net: phy: fix may not suspend when phy has WoL WangYuli
2024-11-11 8:24 ` Wentao Guan
2024-11-11 17:47 ` [PATCH] " Andrew Lunn
2024-11-11 17:53 ` Wentao Guan
2024-11-11 8:49 ` Wentao Guan
2024-11-11 10:05 ` [PATCH] " Russell King (Oracle)
2024-11-11 10:59 ` Wentao Guan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_4B3AACEA45FBC48A019C11B2@qq.com \
--to=guanwentao@uniontech$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=geert+renesas@glider$(echo .)be \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=mugunthanvnm@ti$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sebastian.hesselbarth@gmail$(echo .)com \
--cc=wangyuli@uniontech$(echo .)com \
--cc=zhanjun@uniontech$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox