From: Vlad Buslov <vladbu@mellanox•com>
To: Cong Wang <xiyou.wangcong@gmail•com>
Cc: Linux Kernel Network Developers <netdev@vger•kernel.org>,
Jamal Hadi Salim <jhs@mojatatu•com>,
Jiri Pirko <jiri@resnulli•us>, David Miller <davem@davemloft•net>
Subject: Re: [PATCH net-next] net: sched: don't release block->lock when dumping chains
Date: Mon, 4 Mar 2019 14:14:20 +0000 [thread overview]
Message-ID: <vbfr2bmohfr.fsf@mellanox.com> (raw)
In-Reply-To: <CAM_iQpVjfcB52RdyND5b_AejmbFKaArdZjT5Y7QDFYuC=thCsQ@mail.gmail.com>
On Sat 02 Mar 2019 at 00:08, Cong Wang <xiyou.wangcong@gmail•com> wrote:
> On Thu, Feb 28, 2019 at 6:53 AM Vlad Buslov <vladbu@mellanox•com> wrote:
>>
>>
>> On Wed 27 Feb 2019 at 23:03, Cong Wang <xiyou.wangcong@gmail•com> wrote:
>> > On Tue, Feb 26, 2019 at 8:10 AM Vlad Buslov <vladbu@mellanox•com> wrote:
>> >>
>> >>
>> >> On Tue 26 Feb 2019 at 00:15, Cong Wang <xiyou.wangcong@gmail•com> wrote:
>> >> > On Mon, Feb 25, 2019 at 7:45 AM Vlad Buslov <vladbu@mellanox•com> wrote:
>> >> >>
>> >> >> Function tc_dump_chain() obtains and releases block->lock on each iteration
>> >> >> of its inner loop that dumps all chains on block. Outputting chain template
>> >> >> info is fast operation so locking/unlocking mutex multiple times is an
>> >> >> overhead when lock is highly contested. Modify tc_dump_chain() to only
>> >> >> obtain block->lock once and dump all chains without releasing it.
>> >> >>
>> >> >> Signed-off-by: Vlad Buslov <vladbu@mellanox•com>
>> >> >> Suggested-by: Cong Wang <xiyou.wangcong@gmail•com>
>> >> >
>> >> > Thanks for the followup!
>> >> >
>> >> > Isn't it similar for __tcf_get_next_proto() in tcf_chain_dump()?
>> >> > And for tc_dump_tfilter()?
>> >>
>> >> Not really. These two dump all tp filters and not just a template, which
>> >> is O(n) on number of filters and can be slow because it calls hw offload
>> >> API for each of them. Our typical use-case involves periodic filter dump
>> >> (to update stats) while multiple concurrent user-space threads are
>> >> updating filters, so it is important for them to be able to execute in
>> >> parallel.
>> >
>> > Hmm, but if these are read-only, you probably don't even need a
>> > mutex, you can just use RCU read lock to protect list iteration
>> > and you still can grab the refcnt in the same way.
>>
>> That is how it worked in my initial implementation. However, it doesn't
>> work with hw offloads because driver callbacks can sleep.
>
> Hmm? You drop RCU read lock after grabbing the refcnt,
> right? If so what's the problem with sleeping?
Okay, I misunderstood your suggestion. In tc_dump_tfilter() we can't use
RCU in __tcf_get_next_chain() because chain reference counters are not
atomic and require protection of block->lock. __tcf_get_next_proto()
requires chain->filter_chain_lock because it checks 'deleting' flag
besides taking reference to tp.
prev parent reply other threads:[~2019-03-04 14:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 15:45 [PATCH net-next] net: sched: don't release block->lock when dumping chains Vlad Buslov
2019-02-25 18:25 ` David Miller
2019-02-26 0:15 ` Cong Wang
2019-02-26 16:09 ` Vlad Buslov
2019-02-27 23:03 ` Cong Wang
2019-02-28 14:53 ` Vlad Buslov
2019-03-02 0:08 ` Cong Wang
2019-03-04 14:14 ` Vlad Buslov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vbfr2bmohfr.fsf@mellanox.com \
--to=vladbu@mellanox$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=netdev@vger$(echo .)kernel.org \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox